mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-20 23:46:14 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ace2_inner: Factor out duplicate line number div creation

Browse source
This commit is contained in:
Richard Hansen 2021-08-14 21:36:08 -04:00
parent 3237f8d123
commit aad75e4661
1 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/static/js/ace2_inner.js
View file

@ -65,14 +65,15 @@ function Ace2Inner(editorInfo, cssManagers) {
const sideDiv = outerDoc.getElementById('sidediv'); const sideDiv = outerDoc.getElementById('sidediv');
const lineMetricsDiv = outerDoc.getElementById('linemetricsdiv'); const lineMetricsDiv = outerDoc.getElementById('linemetricsdiv');
const sideDivInner = outerDoc.getElementById('sidedivinner'); const sideDivInner = outerDoc.getElementById('sidedivinner');
(() => { const appendNewSideDivLine = () => {
const lineDiv = outerDoc.createElement('div'); const lineDiv = outerDoc.createElement('div');
sideDivInner.appendChild(lineDiv); sideDivInner.appendChild(lineDiv);
const lineSpan = outerDoc.createElement('span'); const lineSpan = outerDoc.createElement('span');
lineSpan.classList.add('line-number'); lineSpan.classList.add('line-number');
lineSpan.appendChild(outerDoc.createTextNode('1')); lineSpan.appendChild(outerDoc.createTextNode(sideDivInner.children.length));
lineDiv.appendChild(lineSpan); lineDiv.appendChild(lineSpan);
})(); };
appendNewSideDivLine();
const scroll = Scroll.init(outerWin); const scroll = Scroll.init(outerWin);
@ -3591,12 +3592,7 @@ function Ace2Inner(editorInfo, cssManagers) {
if (newNumLines < 1) newNumLines = 1; if (newNumLines < 1) newNumLines = 1;
if (newNumLines !== sideDivInner.children.length) { if (newNumLines !== sideDivInner.children.length) {
while (sideDivInner.children.length < newNumLines) { while (sideDivInner.children.length < newNumLines) appendNewSideDivLine();
const div = outerDoc.createElement('DIV');
sideDivInner.appendChild(div);
$(div).append($(`<span class='line-number'>${sideDivInner.children.length}</span>`));
}
// Remove extra lines // Remove extra lines
while (sideDivInner.children.length > newNumLines) { while (sideDivInner.children.length > newNumLines) {
sideDivInner.removeChild(sideDivInner.lastChild); sideDivInner.removeChild(sideDivInner.lastChild);