From aad75e4661698902f89a3c4f1811c3c44613691c Mon Sep 17 00:00:00 2001
From: Richard Hansen <rhansen@rhansen.org>
Date: Sat, 14 Aug 2021 21:36:08 -0400
Subject: [PATCH] ace2_inner: Factor out duplicate line number div creation

---
 src/static/js/ace2_inner.js | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/src/static/js/ace2_inner.js b/src/static/js/ace2_inner.js
index a46978139..f384ddafd 100644
--- a/src/static/js/ace2_inner.js
+++ b/src/static/js/ace2_inner.js
@@ -65,14 +65,15 @@ function Ace2Inner(editorInfo, cssManagers) {
   const sideDiv = outerDoc.getElementById('sidediv');
   const lineMetricsDiv = outerDoc.getElementById('linemetricsdiv');
   const sideDivInner = outerDoc.getElementById('sidedivinner');
-  (() => {
+  const appendNewSideDivLine = () => {
     const lineDiv = outerDoc.createElement('div');
     sideDivInner.appendChild(lineDiv);
     const lineSpan = outerDoc.createElement('span');
     lineSpan.classList.add('line-number');
-    lineSpan.appendChild(outerDoc.createTextNode('1'));
+    lineSpan.appendChild(outerDoc.createTextNode(sideDivInner.children.length));
     lineDiv.appendChild(lineSpan);
-  })();
+  };
+  appendNewSideDivLine();
 
   const scroll = Scroll.init(outerWin);
 
@@ -3591,12 +3592,7 @@ function Ace2Inner(editorInfo, cssManagers) {
     if (newNumLines < 1) newNumLines = 1;
 
     if (newNumLines !== sideDivInner.children.length) {
-      while (sideDivInner.children.length < newNumLines) {
-        const div = outerDoc.createElement('DIV');
-        sideDivInner.appendChild(div);
-        $(div).append($(`<span class='line-number'>${sideDivInner.children.length}</span>`));
-      }
-
+      while (sideDivInner.children.length < newNumLines) appendNewSideDivLine();
       // Remove extra lines
       while (sideDivInner.children.length > newNumLines) {
         sideDivInner.removeChild(sideDivInner.lastChild);