update some docs, todo.txt

This commit is contained in:
Robin Scholtes 2023-05-15 22:01:23 +12:00
parent 4b030c7d61
commit 6e6d6e0ed5
3 changed files with 4 additions and 16 deletions

View file

@ -445,7 +445,7 @@ class App {
/** /**
* Resets favourite operations back to the default as specified in the view constructor and * Resets favourite operations to the default as specified in the view constructor and
* refreshes the operation list. * refreshes the operation list.
*/ */
resetFavourites() { resetFavourites() {

View file

@ -4,13 +4,7 @@
--- ---
#### Mobile UI ( on real device ): #### Mobile UI ( on real device ):
- maybe a bit annoying that the fav cat opens whenever you add a new fav via icon-fav-click on mobile - maybe a bit annoying that the fav cat opens after adding a favourite, after tapping 'search'. find HTMLCat and populateOperationsList
- backspace on fs view should close max view. Keep making the same mistake and navigating away when for instance recipe
is expanded and double click the window to fs > resolve. Reset layout
### JS:
- `core/Recipe.mjs`, `core/lib/Magic.js`, `core/ChefWorker.js` return imports to original
> but then dev wont run anymore :(
### Misc: ### Misc:
- delete this file when done :) - delete this file when done :)

View file

@ -624,14 +624,8 @@ class RecipeWaiter {
/** /**
* Update which items are selected in op-list. * Update which items are selected in op-list.
* *
* First, all selected classes are removed from op-list, then we get the current * First all selected classes are removed from all op-lists, then we get the current
* recipe-list ingredient names and add 'selected' back to the matching operations. * recipe-list ingredient names and add 'selected' to the matching operations.
*
* Note: It seems a little overkill to nuke all selected classes, but with the current
* code this is a reliable way to make sure the 'selected' operations are always in sync with
* the recipe list ( I think this is preferable to complicating a lot of existing
* code ), I'd recommend to refactor this at one point, but that should go hand in hand
* with a huge code overhaul for another time / issue.
*/ */
updateSelectedOperations() { updateSelectedOperations() {
const recipeListItems = document.querySelectorAll("#rec-list > li"); const recipeListItems = document.querySelectorAll("#rec-list > li");