From 6e6d6e0ed5f5b35fc5d421de468e8451bdd42c0f Mon Sep 17 00:00:00 2001 From: Robin Scholtes Date: Mon, 15 May 2023 22:01:23 +1200 Subject: [PATCH] update some docs, todo.txt --- src/web/App.mjs | 2 +- src/web/TODO.md | 8 +------- src/web/waiters/RecipeWaiter.mjs | 10 ++-------- 3 files changed, 4 insertions(+), 16 deletions(-) diff --git a/src/web/App.mjs b/src/web/App.mjs index 0d0b341d..04842a33 100755 --- a/src/web/App.mjs +++ b/src/web/App.mjs @@ -445,7 +445,7 @@ class App { /** - * Resets favourite operations back to the default as specified in the view constructor and + * Resets favourite operations to the default as specified in the view constructor and * refreshes the operation list. */ resetFavourites() { diff --git a/src/web/TODO.md b/src/web/TODO.md index f1beb042..c39ef973 100644 --- a/src/web/TODO.md +++ b/src/web/TODO.md @@ -4,13 +4,7 @@ --- #### Mobile UI ( on real device ): -- maybe a bit annoying that the fav cat opens whenever you add a new fav via icon-fav-click on mobile -- backspace on fs view should close max view. Keep making the same mistake and navigating away when for instance recipe - is expanded and double click the window to fs > resolve. Reset layout - -### JS: -- `core/Recipe.mjs`, `core/lib/Magic.js`, `core/ChefWorker.js` return imports to original -> but then dev wont run anymore :( +- maybe a bit annoying that the fav cat opens after adding a favourite, after tapping 'search'. find HTMLCat and populateOperationsList ### Misc: - delete this file when done :) diff --git a/src/web/waiters/RecipeWaiter.mjs b/src/web/waiters/RecipeWaiter.mjs index 04aac20c..b77f942e 100755 --- a/src/web/waiters/RecipeWaiter.mjs +++ b/src/web/waiters/RecipeWaiter.mjs @@ -624,14 +624,8 @@ class RecipeWaiter { /** * Update which items are selected in op-list. * - * First, all selected classes are removed from op-list, then we get the current - * recipe-list ingredient names and add 'selected' back to the matching operations. - * - * Note: It seems a little overkill to nuke all selected classes, but with the current - * code this is a reliable way to make sure the 'selected' operations are always in sync with - * the recipe list ( I think this is preferable to complicating a lot of existing - * code ), I'd recommend to refactor this at one point, but that should go hand in hand - * with a huge code overhaul for another time / issue. + * First all selected classes are removed from all op-lists, then we get the current + * recipe-list ingredient names and add 'selected' to the matching operations. */ updateSelectedOperations() { const recipeListItems = document.querySelectorAll("#rec-list > li");