From 24fd5e7aaf67c68f84c6d73f80cf0c6b3024e60a Mon Sep 17 00:00:00 2001 From: Alexander Janke <33967771+alexanderjanke@users.noreply.github.com> Date: Thu, 11 Jun 2020 13:32:18 +0200 Subject: [PATCH 1/2] Use vue-typecast https://vuejs.org/v2/guide/forms.html#number --- src/routes/tools/BaseConverter.vue | 4 ++-- src/routes/tools/UuidGenerator.vue | 2 +- src/utils/helpers.js | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/routes/tools/BaseConverter.vue b/src/routes/tools/BaseConverter.vue index 298aa799..a6d3b4a1 100644 --- a/src/routes/tools/BaseConverter.vue +++ b/src/routes/tools/BaseConverter.vue @@ -8,7 +8,7 @@ label="Input base" outlined type="number" - v-model="inputBase" + v-model.number="inputBase" ref="inputBase" hide-details="auto" :rules="baseRules" @@ -33,7 +33,7 @@ label="Output base" outlined type="number" - v-model="outputBase" + v-model.number="outputBase" ref="outputBase" :rules="baseRules" /> diff --git a/src/routes/tools/UuidGenerator.vue b/src/routes/tools/UuidGenerator.vue index 5eb5c8b1..d62e00af 100644 --- a/src/routes/tools/UuidGenerator.vue +++ b/src/routes/tools/UuidGenerator.vue @@ -5,7 +5,7 @@ { } const isInt = (value) => { - return Number.isInteger(parseFloat(value)); + return Number.isInteger(value); } export { From cc1ac8398bea588e268d6ff53e52eb4f6f79b515 Mon Sep 17 00:00:00 2001 From: Corentin THOMASSET Date: Thu, 11 Jun 2020 16:20:36 +0200 Subject: [PATCH 2/2] chore: updated changelog --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3482c59f..846f6d10 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Next - [fix] [GithubContributors] ordered contributors by contribution count +- [refactor] used vue-typecasting for number inputs ## 1.2.1 - [fix] [UuidGenerator] added quantity validation rules @@ -25,4 +26,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - [fix] remove history move (incompatible with vercel.com) ## 1.0.0 -- First release \ No newline at end of file +- First release