mirror of
https://github.com/CorentinTh/it-tools.git
synced 2025-04-24 08:46:15 -04:00
refactor(c-key-value-list): got rid of table for layout (#611)
This commit is contained in:
parent
c7d4562d3b
commit
7ab9204e96
6 changed files with 49 additions and 33 deletions
|
@ -1,14 +1,15 @@
|
|||
import { type Page, expect, test } from '@playwright/test';
|
||||
import _ from 'lodash';
|
||||
|
||||
async function extractIbanInfo({ page }: { page: Page }) {
|
||||
const tdHandles = await page.locator('table tr td').elementHandles();
|
||||
const tdTextContents = await Promise.all(tdHandles.map(el => el.textContent()));
|
||||
const itemsLines = await page
|
||||
.locator('.c-key-value-list__item').all();
|
||||
|
||||
return _.chain(tdTextContents)
|
||||
.map(tdTextContent => tdTextContent?.trim().replace(' Copy to clipboard', ''))
|
||||
.chunk(2)
|
||||
.value();
|
||||
return await Promise.all(
|
||||
itemsLines.map(async item => [
|
||||
(await item.locator('.c-key-value-list__key').textContent() ?? '').trim(),
|
||||
(await item.locator('.c-key-value-list__value').textContent() ?? '').trim(),
|
||||
]),
|
||||
);
|
||||
}
|
||||
|
||||
test.describe('Tool - Iban validator and parser', () => {
|
||||
|
@ -41,7 +42,7 @@ test.describe('Tool - Iban validator and parser', () => {
|
|||
|
||||
expect(ibanInfo).toEqual([
|
||||
['Is IBAN valid ?', 'No'],
|
||||
['IBAN errors', 'Wrong account bank branch checksumWrong IBAN checksum Copy to clipboard'],
|
||||
['IBAN errors', 'Wrong account bank branch checksum Wrong IBAN checksum'],
|
||||
['Is IBAN a QR-IBAN ?', 'No'],
|
||||
['Country code', 'N/A'],
|
||||
['BBAN', 'N/A'],
|
||||
|
|
|
@ -60,7 +60,7 @@ const ibanExamples = [
|
|||
<div>
|
||||
<c-input-text v-model:value="rawIban" placeholder="Enter an IBAN to check for validity..." test-id="iban-input" />
|
||||
|
||||
<c-key-value-list :items="ibanInfo" my-5 />
|
||||
<c-key-value-list :items="ibanInfo" my-5 data-test-id="iban-info" />
|
||||
|
||||
<c-card title="Valid IBAN examples">
|
||||
<div v-for="iban in ibanExamples" :key="iban">
|
||||
|
|
27
src/ui/c-key-value-list/c-key-value-list-item.vue
Normal file
27
src/ui/c-key-value-list/c-key-value-list-item.vue
Normal file
|
@ -0,0 +1,27 @@
|
|||
<script lang="ts" setup>
|
||||
import _ from 'lodash';
|
||||
import type { CKeyValueListItem } from './c-key-value-list.types';
|
||||
|
||||
const props = defineProps<{ item: CKeyValueListItem }>();
|
||||
const { item } = toRefs(props);
|
||||
</script>
|
||||
|
||||
<template>
|
||||
<div v-if="_.isArray(item.value)">
|
||||
<div v-for="value in item.value" :key="value">
|
||||
<c-text-copyable :value="value" :show-icon="item.showCopyButton ?? true" />
|
||||
</div>
|
||||
</div>
|
||||
<div v-else-if="_.isBoolean(item.value)">
|
||||
<c-text-copyable :value="item.value ? 'true' : 'false'" :displayed-value="item.value ? 'Yes' : 'No'" :show-icon="item.showCopyButton ?? true" />
|
||||
</div>
|
||||
<div v-else-if="_.isNumber(item.value)" font-mono>
|
||||
<c-text-copyable :value="String(item.value)" :show-icon="item.showCopyButton ?? true" />
|
||||
</div>
|
||||
<div v-else-if="_.isNil(item.value) || item.value === ''" op-70>
|
||||
{{ item.placeholder ?? 'N/A' }}
|
||||
</div>
|
||||
<div v-else>
|
||||
<c-text-copyable :value="item.value" :show-icon="item.showCopyButton ?? true" />
|
||||
</div>
|
||||
</template>
|
|
@ -9,29 +9,13 @@ const formattedItems = computed(() => items.value.filter(item => !_.isNil(item.v
|
|||
</script>
|
||||
|
||||
<template>
|
||||
<table border-collapse table-fixed>
|
||||
<tr v-for="item in formattedItems" :key="item.label">
|
||||
<td py-1 pr-2 text-right font-bold>
|
||||
<div my-5>
|
||||
<div v-for="item in formattedItems" :key="item.label" flex gap-2 py-1 class="c-key-value-list__item">
|
||||
<div flex-basis-180px text-right font-bold class="c-key-value-list__key">
|
||||
{{ item.label }}
|
||||
</td>
|
||||
</div>
|
||||
|
||||
<td v-if="_.isArray(item.value)">
|
||||
<div v-for="value in item.value" :key="value">
|
||||
<c-text-copyable :value="value" :show-icon="item.showCopyButton ?? true" />
|
||||
</div>
|
||||
</td>
|
||||
<td v-else-if="_.isBoolean(item.value)">
|
||||
<c-text-copyable :value="item.value ? 'true' : 'false'" :displayed-value="item.value ? 'Yes' : 'No'" :show-icon="item.showCopyButton ?? true" />
|
||||
</td>
|
||||
<td v-else-if="_.isNumber(item.value)" font-mono>
|
||||
<c-text-copyable :value="String(item.value)" :show-icon="item.showCopyButton ?? true" />
|
||||
</td>
|
||||
<td v-else-if="_.isNil(item.value) || item.value === ''" op-70>
|
||||
{{ item.placeholder ?? 'N/A' }}
|
||||
</td>
|
||||
<td v-else>
|
||||
<c-text-copyable :value="item.value" :show-icon="item.showCopyButton ?? true" />
|
||||
</td>
|
||||
</tr>
|
||||
</table>
|
||||
<c-key-value-list-item :item="item" class="c-key-value-list__value" />
|
||||
</div>
|
||||
</div>
|
||||
</template>
|
||||
|
|
|
@ -19,7 +19,10 @@ const isTargetHovered = useElementHover(targetRef);
|
|||
'op-100 scale-100': isTargetHovered,
|
||||
}"
|
||||
>
|
||||
<slot name="tooltip">
|
||||
<slot
|
||||
v-if="isTargetHovered"
|
||||
name="tooltip"
|
||||
>
|
||||
{{ tooltip }}
|
||||
</slot>
|
||||
</div>
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue