mirrors/it-tools
1
0
Fork 0
mirror of https://github.com/CorentinTh/it-tools.git synced 2025-05-05 13:57:10 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix(integer-base-converter): fix conversion for number of more than 32bits

Browse source
This commit is contained in:
ShareVB 2024-02-04 13:58:01 +01:00
parent e336ebe6bb
commit 34357dde7c
2 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/tools/integer-base-converter/integer-base-converter.model.test.ts
View file

@ -26,6 +26,9 @@ describe('integer-base-converter', () => {
expect(convertBase({ value: '0b10101010', fromBase: -1, toBase: 10 })).toEqual('170'); expect(convertBase({ value: '0b10101010', fromBase: -1, toBase: 10 })).toEqual('170');
expect(convertBase({ value: '0b_1010_1010', fromBase: -1, toBase: 10 })).toEqual('170'); expect(convertBase({ value: '0b_1010_1010', fromBase: -1, toBase: 10 })).toEqual('170');
expect(convertBase({ value: '192,654', fromBase: 10, toBase: 8 })).toEqual('570216'); expect(convertBase({ value: '192,654', fromBase: 10, toBase: 8 })).toEqual('570216');
expect(convertBase({ value: '42540766411283223938465490632011909384', fromBase: 10, toBase: 10 })).toEqual('42540766411283223938465490632011909384');
expect(convertBase({ value: '42540766411283223938465490632011909384', fromBase: 10, toBase: 16 })).toEqual('20010db8000085a300000000ac1f8908');
expect(convertBase({ value: '20010db8000085a300000000ac1f8908', fromBase: 16, toBase: 10 })).toEqual('42540766411283223938465490632011909384');
}); });
}); });
}); });

10
src/tools/integer-base-converter/integer-base-converter.model.ts
View file

@ -46,16 +46,16 @@ export function convertBase(
let decValue = cleanedValue let decValue = cleanedValue
.split('') .split('')
.reverse() .reverse()
.reduce((carry: number, digit: string, index: number) => { .reduce((carry: bigint, digit: string, index: number) => {
if (!fromRange.includes(digit)) { if (!fromRange.includes(digit)) {
throw new Error(`Invalid digit "${digit}" for base ${finalFromBase}.`); throw new Error(`Invalid digit "${digit}" for base ${finalFromBase}.`);
} }
return (carry += fromRange.indexOf(digit) * finalFromBase ** index); return (carry += BigInt(fromRange.indexOf(digit)) * BigInt(finalFromBase) ** BigInt(index));
}, 0); }, 0n);
let newValue = ''; let newValue = '';
while (decValue > 0) { while (decValue > 0) {
newValue = toRange[decValue % toBase] + newValue; newValue = toRange[Number(decValue % BigInt(toBase))] + newValue;
decValue = (decValue - (decValue % toBase)) / toBase; decValue = (decValue - (decValue % BigInt(toBase))) / BigInt(toBase);
} }
return newValue || '0'; return newValue || '0';
} }