etherpad-lite/src/node/db
John McLear ce83181ac3
Lgtm bugfixes (#4838)
* code tidy up: always evaluates

* tidy up: is always true

* tidy up: remove unused code

* always true/false variables

* unused variable

* tidy up: remove unused code in caretPosition.js

* for squash: Revert "tidy up: remove unused code in caretPosition.js"

The `if` condition was previously always true, so the body should be
preserved. If the body is preserved, other logic can be deleted. I
opened PR #4845 to clean it all up.

This reverts commit 75b03e5a7d.

* for squash: simplify

* for squash: Explain that the getter is used for its side effects

It's very weird to call a getter without using its return value. Add a
comment explaining why this is done so that the reader doesn't get
confused.

* for squash: Revert "tidy up: remove unused code"

The exception test was the purpose of the code.

This reverts commit 85153b1676.

* for squash: Log the tsort results

Co-authored-by: Richard Hansen <rhansen@rhansen.org>
2021-02-22 08:26:35 +00:00
..
API.js Lgtm bugfixes (#4838) 2021-02-22 08:26:35 +00:00
AuthorManager.js lint: src/node/db/AuthorManager.js 2021-01-25 17:56:27 -05:00
DB.js docs: fixed typos 2021-02-03 00:30:07 +01:00
GroupManager.js lint: src/node/db/GroupManager.js 2021-01-25 17:56:27 -05:00
Pad.js Lgtm bugfixes (#4838) 2021-02-22 08:26:35 +00:00
PadManager.js lint: PadManager.js 2021-02-21 21:02:59 -05:00
ReadOnlyManager.js lint: src/node/db/ReadOnlyManager.js 2021-01-25 17:56:28 -05:00
SecurityManager.js lint: src/node/db/SecurityManager.js 2021-01-25 17:56:28 -05:00
SessionManager.js lint: src/node/db/SessionManager.js 2021-01-25 17:56:28 -05:00
SessionStore.js lint: src/node/db/SessionStore.js 2021-01-25 22:53:09 -05:00