mirror of
https://github.com/ether/etherpad-lite.git
synced 2025-06-17 11:44:51 -04:00
2ea8ea1275
Also add symlinks from the old `bin/` and `tests/` locations to avoid
breaking scripts and other tools.
Motivations:
* Scripts and tests no longer have to do dubious things like:
require('ep_etherpad-lite/node_modules/foo')
to access packages installed as dependencies in
`src/package.json`.
* Plugins can access the backend test helper library in a non-hacky
way:
require('ep_etherpad-lite/tests/backend/common')
* We can delete the top-level `package.json` without breaking our
ability to lint the files in `bin/` and `tests/`.
Deleting the top-level `package.json` has downsides: It will cause
`npm` to print warnings whenever plugins are installed, npm will
no longer be able to enforce a plugin's peer dependency on
ep_etherpad-lite, and npm will keep deleting the
`node_modules/ep_etherpad-lite` symlink that points to `../src`.
But there are significant upsides to deleting the top-level
`package.json`: It will drastically speed up plugin installation
because `npm` doesn't have to recursively walk the dependencies in
`src/package.json`. Also, deleting the top-level `package.json`
avoids npm's horrible dependency hoisting behavior (where it moves
stuff from `src/node_modules/` to the top-level `node_modules/`
directory). Dependency hoisting causes numerous mysterious
problems such as silent failures in `npm outdated` and `npm
update`. Dependency hoisting also breaks plugins that do:
require('ep_etherpad-lite/node_modules/foo')
38 lines
1.1 KiB
JavaScript
38 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
describe('strikethrough button', function () {
|
|
// create a new pad before each test run
|
|
beforeEach(function (cb) {
|
|
helper.newPad(cb);
|
|
this.timeout(60000);
|
|
});
|
|
|
|
it('makes text strikethrough', function (done) {
|
|
const inner$ = helper.padInner$;
|
|
const chrome$ = helper.padChrome$;
|
|
|
|
// get the first text element out of the inner iframe
|
|
const $firstTextElement = inner$('div').first();
|
|
|
|
// select this text element
|
|
$firstTextElement.sendkeys('{selectall}');
|
|
|
|
// get the strikethrough button and click it
|
|
const $strikethroughButton = chrome$('.buttonicon-strikethrough');
|
|
$strikethroughButton.click();
|
|
|
|
// ace creates a new dom element when you press a button, just get the first text element again
|
|
const $newFirstTextElement = inner$('div').first();
|
|
|
|
// is there a <i> element now?
|
|
const isstrikethrough = $newFirstTextElement.find('s').length === 1;
|
|
|
|
// expect it to be strikethrough
|
|
expect(isstrikethrough).to.be(true);
|
|
|
|
// make sure the text hasn't changed
|
|
expect($newFirstTextElement.text()).to.eql($firstTextElement.text());
|
|
|
|
done();
|
|
});
|
|
});
|