mirror of
https://github.com/ether/etherpad-lite.git
synced 2025-05-11 01:31:29 -04:00
0de41ee087
Use MutationObserver to detect if a saveProgress event was received,
which will trigger an animation.
Before this, `helper.admin$('#response').is(':visible')` was true
after the page loaded and before clicking the Save button, so there
was a possibility that after clicking Save, but before sending the
socketio message to the server, the visibility is checked and returns
true, so the page gets reloaded before the changed settings have been
saved.
90 lines
3.1 KiB
JavaScript
90 lines
3.1 KiB
JavaScript
'use strict';
|
|
|
|
describe('Admin > Settings', function () {
|
|
this.timeout(480000);
|
|
|
|
before(async function () {
|
|
let success = false;
|
|
$.ajax({
|
|
url: `${location.protocol}//admin:changeme@${location.hostname}:${location.port}/admin/`,
|
|
type: 'GET',
|
|
success: () => success = true,
|
|
});
|
|
await helper.waitForPromise(() => success === true);
|
|
});
|
|
|
|
beforeEach(async function () {
|
|
helper.newAdmin('settings');
|
|
// needed, because the load event is fired to early
|
|
await helper.waitForPromise(
|
|
() => helper.admin$ && helper.admin$('.settings').val().length > 0, 5000);
|
|
});
|
|
|
|
it('Are Settings visible, populated, does save work', async function () {
|
|
const save = async () => {
|
|
const p = new Promise((resolve) => {
|
|
const observer = new MutationObserver(() => { resolve(); observer.disconnect(); });
|
|
observer.observe(
|
|
helper.admin$('#response')[0], {attributes: true, childList: false, subtree: false});
|
|
});
|
|
helper.admin$('#saveSettings').click();
|
|
await p;
|
|
};
|
|
|
|
// save old value
|
|
const settings = helper.admin$('.settings').val();
|
|
const settingsLength = settings.length;
|
|
|
|
// set new value
|
|
helper.admin$('.settings').val((_, text) => `/* test */\n${text}`);
|
|
await helper.waitForPromise(
|
|
() => settingsLength + 11 === helper.admin$('.settings').val().length, 5000);
|
|
await save();
|
|
|
|
// new value for settings.json should now be saved
|
|
// reset it to the old value
|
|
helper.newAdmin('settings');
|
|
await helper.waitForPromise(
|
|
() => helper.admin$ &&
|
|
helper.admin$('.settings').val().length === settingsLength + 11, 20000);
|
|
|
|
// replace the test value with a line break
|
|
helper.admin$('.settings').val((_, text) => text.replace('/* test */\n', ''));
|
|
await helper.waitForPromise(() => settingsLength === helper.admin$('.settings').val().length);
|
|
await save();
|
|
|
|
// settings should have the old value
|
|
helper.newAdmin('settings');
|
|
await helper.waitForPromise(
|
|
() => helper.admin$ && helper.admin$('.settings').val().length === settingsLength &&
|
|
settings === helper.admin$('.settings').val(), 20000);
|
|
});
|
|
|
|
it('restart works', async function () {
|
|
const getStartTime = async () => {
|
|
try {
|
|
const {httpStartTime} = await $.ajax({
|
|
url: new URL('/stats', window.location.href),
|
|
method: 'GET',
|
|
dataType: 'json',
|
|
timeout: 450, // Slightly less than the waitForPromise() interval.
|
|
});
|
|
return httpStartTime;
|
|
} catch (err) {
|
|
document.getElementById('console').append(
|
|
`an error occurred: ${err.message} of type ${err.name}\n`);
|
|
return null;
|
|
}
|
|
};
|
|
let oldStartTime;
|
|
await helper.waitForPromise(async () => {
|
|
oldStartTime = await getStartTime();
|
|
return oldStartTime != null && oldStartTime > 0;
|
|
}, 1000, 500);
|
|
helper.admin$('#restartEtherpad').click();
|
|
await helper.waitForPromise(async () => {
|
|
const startTime = await getStartTime();
|
|
return startTime != null && startTime > oldStartTime;
|
|
}, 60000, 500);
|
|
});
|
|
});
|