Richard Hansen
f00b1ae89b
Merge branch 'master' into develop
2021-11-28 23:10:45 -05:00
Richard Hansen
7c870f8a58
Pad: Add strict validation checks
2021-11-28 22:28:55 -05:00
Richard Hansen
2608a81654
Changeset: Stricter validation checks
2021-11-28 22:28:55 -05:00
Richard Hansen
89fe40e080
Changeset: Migrate from OpIter to deserializeOps()
2021-11-23 01:21:49 -05:00
Richard Hansen
0eca0251f2
Changeset: Use a generator to implement OpIter
2021-11-23 01:21:49 -05:00
Richard Hansen
a4aec006dc
Changeset: Turn opIterator() into a real class
2021-11-23 01:21:12 -05:00
Richard Hansen
86959f7ebc
Changeset: Throw on unexpected chars while iterating ops
2021-11-23 01:21:12 -05:00
Richard Hansen
657492e191
Changeset: Turn newOp() into a real class
2021-11-23 01:21:12 -05:00
Richard Hansen
fba0bb6dff
Changeset: Turn textLinesMutator() into a real class
2021-11-23 01:21:12 -05:00
Richard Hansen
dab881139d
Pad: Fix copyPadWithoutHistory apool corruption bug
2021-11-22 18:40:22 -05:00
Richard Hansen
d74dd235a4
Changeset: Replace appendATextToAssembler() with a generator
2021-11-22 18:10:37 -05:00
Richard Hansen
2fc06a0884
Changeset: Add TODO comments for issues noticed
2021-11-21 04:11:41 -05:00
Richard Hansen
f1eb7a25a6
Changeset: Migrate to the new attribute API
2021-11-21 04:11:41 -05:00
Richard Hansen
1f227200da
Replace separate attrib key, value calls with single pair call
2021-11-21 04:11:41 -05:00
Richard Hansen
6cf2055199
Changeset: New API to simplify attribute processing
2021-11-21 04:11:41 -05:00
Richard Hansen
982d8ad0f2
Changeset: Refactor makeAttribsString for readability
2021-11-21 04:11:41 -05:00
Richard Hansen
9e7b142bb7
Invert conditions to improve readability
2021-11-21 04:11:41 -05:00
Richard Hansen
93abc31936
changesettracker: Fix author attribute ID fetch
2021-11-21 04:11:41 -05:00
Richard Hansen
d0e74ada2f
changesettracker: Remove unnecessary .numToAttrib check
2021-11-21 04:11:41 -05:00
Richard Hansen
a65498e849
Changeset: Move SmartOpAssembler.appendOpWithText() to a standalone function
2021-11-14 04:17:00 -05:00
Richard Hansen
eae814f5a0
pad_utils: New warnWithStack() function
2021-11-14 04:15:10 -05:00
Richard Hansen
1bbe0d9215
Changeset: Use in check to help TypeScript narrowing
2021-11-13 17:44:38 -05:00
Richard Hansen
4f4a775d9e
Changeset: Improve handling of missing attribute in old pool
2021-11-13 17:44:38 -05:00
Richard Hansen
b62534a6b2
Changeset: Use Maps to simplify attribute processing
2021-11-13 17:44:38 -05:00
Richard Hansen
9401ae876b
Changeset: Sort attributes by keys, not full string rep
2021-11-13 17:44:38 -05:00
Richard Hansen
1cad5d881a
Changeset: Use for...of iteration to improve readability
2021-11-13 17:44:38 -05:00
Richard Hansen
6d5b737140
Changeset: Replace .apply() with spread operator
2021-11-13 17:44:38 -05:00
Richard Hansen
9c17b03660
Changeset: Require Op opcode and attribs to be strings
2021-11-13 17:44:38 -05:00
Richard Hansen
0ae8fb1441
Changeset: Use string concatenation instead of array join
...
People report that string concatenation is faster. Also, I think it's
more readable.
2021-11-13 17:44:38 -05:00
Richard Hansen
097f2623c6
Changeset: Add sanity checks to slicerZipperFunc()
2021-11-13 17:44:38 -05:00
Richard Hansen
efeb69b4ea
Changeset: Simplify slicerZipperFunc()
2021-11-13 17:44:38 -05:00
Richard Hansen
42d4d8269c
Changeset: Refactor appendATextToAssembler() for readability
2021-11-13 17:44:38 -05:00
Richard Hansen
ca5bdddc59
Changeset: Use break instead of done variable
2021-11-13 17:44:38 -05:00
Richard Hansen
44d99733c6
Changeset: Check .hasNext() before calling .next()
2021-11-13 17:44:38 -05:00
Richard Hansen
1955e7b263
Changeset: Replace output params with return values
...
This improves readability and reduces the chances of introducing a
bug.
2021-11-13 17:44:38 -05:00
Richard Hansen
94f5507671
Changeset: Improve copyOp() API
...
Use `Object.assign()` to implement `copyOp()`, which simplifies the
code and provides a return value. Also make the second op optional.
2021-11-13 17:44:38 -05:00
Richard Hansen
02ef78e174
Changeset: Make sure opOut is cleared
...
`slicerZipperFunc()` previously assumed the provided `opOut` argument
was a null Op. Enforce this by clearing it at the beginning.
2021-11-13 17:44:38 -05:00
Richard Hansen
18a6b7279c
Changeset: Only pass strings to parseNum()
2021-11-13 17:44:38 -05:00
Richard Hansen
7ec0d5f385
Changeset: Remove unnecessary linesApplySplice()
2021-11-13 17:44:38 -05:00
Richard Hansen
37bb297e76
Changeset: Improve logged error message
...
I saw this on a production system today and wanted more information.
2021-11-13 17:44:38 -05:00
Richard Hansen
7fa9b07116
Changeset: Invert conditions to improve readability
2021-11-13 17:44:38 -05:00
Richard Hansen
b29e59419e
Changeset: Factor out duplicate code
2021-11-13 17:44:38 -05:00
Richard Hansen
4a65c2c8ff
Changeset: Unexport unnecessarily exported functions
...
These functions aren't used outside of this file.
2021-11-13 17:44:38 -05:00
Richard Hansen
085bc8cbb3
plugins: Don't create .ep_initialized files
...
These files cause problems with Docker images and read-only
directories/mounts, and they have dubious value (any install-time
setup should instead be done at startup).
2021-11-13 17:43:33 -05:00
Richard Hansen
0f7c5a8782
lint: Use window. to avoid global declaration
2021-11-12 23:45:05 -05:00
webzwo0i
8b73b911c9
Changeset: Use string templates
...
Co-authored-by: Richard Hansen <rhansen@rhansen.org>
2021-11-09 01:05:53 +01:00
Richard Hansen
cc688f7367
ace: Delete dead code
2021-11-07 23:24:39 -05:00
Richard Hansen
5283bfc14a
linestylefilter: Delete unused arguments
2021-11-07 23:24:39 -05:00
Richard Hansen
dd8ec4e291
Changeset: Remove unused lastIndex() method from op iterator
2021-11-07 23:24:39 -05:00
Richard Hansen
0fd2a46783
Changeset: Remove unused start index parameter for opIterator()
2021-11-07 23:24:39 -05:00
