Richard Hansen
b0862cd030
ace: Delete all $$INCLUDE_CSS logic
...
The intention of the deleted code was to reduce the number of fetches,
but it only saved a single fetch due to implementation flaws. The
right way to reduce the number of fetches is to use a bundling
technology such as webpack, and this change makes it easier to do so.
2021-03-01 14:32:33 +00:00
Richard Hansen
66d3ac3783
ace: Debug logging
2021-03-01 14:32:33 +00:00
Richard Hansen
a17f9bf3cf
ace: Build the outer and inner iframes programmatically
...
This makes the code easier to read and it silences Chrome's
`document.write()` warning:
https://developers.google.com/web/updates/2016/08/removing-document-write
2021-03-01 14:32:33 +00:00
Richard Hansen
c696732838
ace: Asyncify Ace2Editor.init()
2021-03-01 14:32:33 +00:00
Richard Hansen
159fd5bdeb
ace: Simplify passing of editorInfo
2021-03-01 14:32:33 +00:00
Richard Hansen
e57829183d
ace: Pass objects to Ace2Inner via function args
2021-03-01 14:32:33 +00:00
Richard Hansen
6fe0154129
ace: Use absolute URLs when building iframes
...
This isn't strictly necessary right now, but will become
necessary (due to a Safari quirk) when we change to building the
iframes programmatically (vs. the current `document.write()`
approach).
2021-03-01 14:32:33 +00:00
Richard Hansen
9cfc2fb801
ace: Simplify the aceEditorCSS hook map function
2021-03-01 14:32:33 +00:00
Richard Hansen
94c221586c
ace: Factor out duplicated $$INCLUDE_CSS code
2021-03-01 14:32:33 +00:00
Richard Hansen
54df7f3728
ace: Delete unused clientVars.disableCustomScriptsAndStyles
2021-03-01 14:32:33 +00:00
Richard Hansen
d84447290e
ace: Delete unnecessary IIFE
2021-03-01 14:32:33 +00:00
Richard Hansen
3a311d2182
ace: Lint and simplify script strings
2021-03-01 14:32:33 +00:00
Richard Hansen
c9b1f17f25
ace: Format script strings for readability
2021-03-01 14:32:33 +00:00
Richard Hansen
b3416c4eeb
ace: Delete ignored class attribute
2021-03-01 14:32:33 +00:00
Richard Hansen
c9c8b27854
ace: Delete unused Ace2Editor.getFrame() method
2021-03-01 14:32:33 +00:00
Richard Hansen
3667f2ca0e
Ace2Inner: Fix missing spread operator on args
...
This fixes a bug that was introduced in commit
c38c34bef4
2021-02-28 08:39:47 +00:00
webzwo0i
348d08c79e
ensure version string is attached for inner frame resources
2021-02-27 16:28:12 +00:00
webzwo0i
01dd9f5440
speed up page load
2021-02-27 16:28:12 +00:00
John McLear
ba2004cb2d
nice-select restore to working
...
I accidently committed a breaking change in 1b8cd0747d/src/static/js/vendors/nice-select.js
2021-02-27 16:23:39 +00:00
webzwo0i
15dba7d886
move underscore to its old place and remove unnecessary packages ( #4876 )
2021-02-27 00:10:53 -05:00
webzwo0i
fa29858a4e
avoid manually including require-kernel in ace.js
2021-02-25 16:59:06 +00:00
Richard Hansen
1908bedabe
caretPosition: Clarify comment in getPosition()
2021-02-22 11:25:45 +00:00
Richard Hansen
91955609af
caretPosition: Delete pointless logic in getPosition()
...
The `line` variable is unconditionally overwritten later, and the
function calls do not have side effects, so it is safe to delete this
logic.
2021-02-22 11:25:45 +00:00
Richard Hansen
1dbdaf93d7
caretPosition: Delete no-op Range.detach() call
2021-02-22 11:25:45 +00:00
Richard Hansen
5e731dfbfd
caretPosition: Delete unused var in getPosition()
2021-02-22 11:25:45 +00:00
Richard Hansen
02fd0048bf
caretPosition: Invert condition in getPosition() for readability
2021-02-22 11:25:45 +00:00
Richard Hansen
d9c2778d17
plugins: Better fix for LGTM security warning
2021-02-22 09:43:20 +00:00
Richard Hansen
6198e92706
tests: Pass --legacy-peer-deps flag to work around npm v7 bug
...
This flag is unknown to npm v6, but npm v6 silently ignores unknown
flags.
2021-02-22 03:36:12 -05:00
John McLear
ce83181ac3
Lgtm bugfixes ( #4838 )
...
* code tidy up: always evaluates
* tidy up: is always true
* tidy up: remove unused code
* always true/false variables
* unused variable
* tidy up: remove unused code in caretPosition.js
* for squash: Revert "tidy up: remove unused code in caretPosition.js"
The `if` condition was previously always true, so the body should be
preserved. If the body is preserved, other logic can be deleted. I
opened PR #4845 to clean it all up.
This reverts commit 75b03e5a7d85153b1676
2021-02-22 08:26:35 +00:00
John McLear
6b6201b448
null link on plugins and noopener / noreferrer
...
Resolves a (non) security issue brought up by LGTM but I think the noopener and norefferer are good shouts
2021-02-21 19:30:39 +00:00
John McLear
1b8cd0747d
Move vendor libraries to /vendors folder and exclude from LGTM
2021-02-21 15:07:39 +00:00
webzwo0i
0bb3e65020
fix for caching plugin-definitions
2021-02-21 14:31:15 +00:00
John McLear
ee2b32281c
pluginfw: Warn plugins on missing plugin ( #4826 )
...
* pluginfw: Warn plugins on missing plugin
Add functionality to console.warn when a plugin is missing. This will help admins know when people are trying to use plugins that are missing. Resolves https://github.com/ether/etherpad-lite/issues/4730
* pluginfw: importing .etherpad can notify admins of missing plugins
Extending .etherpad imports to notify admins if a missing plugin is present
* Update ImportEtherpad.js
2021-02-21 11:07:13 +00:00
John McLear
77b2f372ab
lint: pad_userlist.js arrow functions
...
This probably needs a good rewrite/refactor to remove self.
2021-02-21 11:05:25 +00:00
John McLear
2511eed472
lint: Changeset.js more literal conditionals
2021-02-21 11:05:25 +00:00
John McLear
8cbd5222dd
lint: pad_userlist.js - remove require browser
2021-02-21 11:05:25 +00:00
John McLear
73b3a2dc54
lint: AttributeManager.js use ES6 method for hasAttrib
2021-02-21 11:05:25 +00:00
John McLear
f86578ffc3
lint: changesettracker.js var > const/let and other easy fixes
2021-02-21 11:05:25 +00:00
John McLear
3635cb6ca6
lint: changesettracker.js long-lines
2021-02-21 11:05:25 +00:00
John McLear
f5f4e3a6d1
lint: changesettracker.js arrow funcs
2021-02-21 11:05:25 +00:00
John McLear
d4b6cbc897
line: broadcast.js
2021-02-21 11:05:25 +00:00
John McLear
3b5b996d84
lint: Changeset no var
2021-02-21 11:05:25 +00:00
John McLear
0b78ad2f90
lint: Changeset.js curly braces in correct position
2021-02-21 11:05:25 +00:00
John McLear
23d7544763
lint: Changeset.js max-len
2021-02-21 11:05:25 +00:00
John McLear
98a0e76a20
lint: Changeset.js opcode eqeqeq checks
2021-02-21 11:05:25 +00:00
John McLear
d91f2b5b07
lint: Changeset.js additional arrow functions
2021-02-21 11:05:25 +00:00
John McLear
acccf56724
lint: Changeset.js arrow-functions
2021-02-21 11:05:25 +00:00
John McLear
cf37f52093
lint: collab_client.js
2021-02-21 11:05:25 +00:00
John McLear
b029edb931
lint: index.js
2021-02-21 11:05:25 +00:00
John McLear
01dd004054
lint: ChangesetUtils
2021-02-21 11:05:25 +00:00
