mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-20 15:36:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

PadMessageHandler: Convert complex if to switch

Browse source
This commit is contained in:
Richard Hansen 2022-02-22 22:41:55 -05:00
parent 05dd9920c5
commit fcfa51bda6
1 changed files with 31 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

46
src/node/handler/PadMessageHandler.js
View file

@ -329,33 +329,37 @@ exports.handleMessage = async (socket, message) => {
} }
// Check what type of message we get and delegate to the other methods // Check what type of message we get and delegate to the other methods
if (message.type === 'CLIENT_READY') { switch (message.type) {
await handleClientReady(socket, message); case 'CLIENT_READY': await handleClientReady(socket, message); break;
} else if (message.type === 'CHANGESET_REQ') { case 'CHANGESET_REQ': await handleChangesetRequest(socket, message); break;
await handleChangesetRequest(socket, message); case 'COLLABROOM':
} else if (message.type === 'COLLABROOM') {
if (readOnly) { if (readOnly) {
messageLogger.warn('Dropped message, COLLABROOM for readonly pad'); messageLogger.warn('Dropped message, COLLABROOM for readonly pad');
} else if (message.data.type === 'USER_CHANGES') { break;
}
switch (message.data.type) {
case 'USER_CHANGES':
stats.counter('pendingEdits').inc(); stats.counter('pendingEdits').inc();
await padChannels.enqueue(thisSession.padId, {socket, message}); await padChannels.enqueue(thisSession.padId, {socket, message});
} else if (message.data.type === 'USERINFO_UPDATE') { break;
await handleUserInfoUpdate(socket, message); case 'USERINFO_UPDATE': await handleUserInfoUpdate(socket, message); break;
} else if (message.data.type === 'CHAT_MESSAGE') { case 'CHAT_MESSAGE': await handleChatMessage(socket, message); break;
await handleChatMessage(socket, message); case 'GET_CHAT_MESSAGES': await handleGetChatMessages(socket, message); break;
} else if (message.data.type === 'GET_CHAT_MESSAGES') { case 'SAVE_REVISION': await handleSaveRevisionMessage(socket, message); break;
await handleGetChatMessages(socket, message); case 'CLIENT_MESSAGE': {
} else if (message.data.type === 'SAVE_REVISION') { const {type} = message.data.payload || {};
await handleSaveRevisionMessage(socket, message); switch (type) {
} else if (message.data.type === 'CLIENT_MESSAGE' && case 'suggestUserName': handleSuggestUserName(socket, message); break;
message.data.payload != null && default: messageLogger.warn(
message.data.payload.type === 'suggestUserName') { `Dropped message, unknown COLLABROOM CLIENT_MESSAGE type: ${type}`);
handleSuggestUserName(socket, message); }
} else { break;
}
default:
messageLogger.warn(`Dropped message, unknown COLLABROOM Data Type ${message.data.type}`); messageLogger.warn(`Dropped message, unknown COLLABROOM Data Type ${message.data.type}`);
} }
} else { break;
messageLogger.warn(`Dropped message, unknown Message Type ${message.type}`); default: messageLogger.warn(`Dropped message, unknown Message Type ${message.type}`);
} }
}; };