mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-05-10 17:22:00 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

tests: admin test timeout increase, bugfix and removal of buggy test (#4762)

Browse source
This commit is contained in:
John McLear 2021-02-12 20:04:42 +00:00 • committed by GitHub
parent 73d31b12a8
commit fcd9adf20d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 29 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/tests/frontend/specs/adminsettings.js
View file

@ -16,7 +16,8 @@ describe('Admin > Settings', function () {
beforeEach(async function () {
helper.newAdmin('settings');
// needed, because the load event is fired to early
await helper.waitForPromise(() => helper.admin$ && helper.admin$('.settings').val().length > 0);
await helper.waitForPromise(
() => helper.admin$ && helper.admin$('.settings').val().length > 0, 5000);
});
it('Are Settings visible, populated, does save work', async function () {
@ -27,16 +28,17 @@ describe('Admin > Settings', function () {
// set new value
helper.admin$('.settings').val((_, text) => `/* test */\n${text}`);
await helper.waitForPromise(
() => settingsLength + 11 === helper.admin$('.settings').val().length);
() => settingsLength + 11 === helper.admin$('.settings').val().length, 5000);
// saves
helper.admin$('#saveSettings').click();
await helper.waitForPromise(() => helper.admin$('#response').is(':visible'));
await helper.waitForPromise(() => helper.admin$('#response').is(':visible'), 5000);
// new value for settings.json should now be saved
// reset it to the old value
helper.newAdmin('settings');
await helper.waitForPromise(() => helper.admin$ && helper.admin$('.settings').val().length > 0);
await helper.waitForPromise(
() => helper.admin$ && helper.admin$('.settings').val().length > 0, 20000);
// replace the test value with a line break
helper.admin$('.settings').val((_, text) => text.replace('/* test */\n', ''));