Merge pull request #1753 from ether/dont-crash-noauth

dont crash on no auth, just a bandaid

src/node/handler/PadMessageHandler.js

@@ -230,6 +230,13 @@ exports.handleMessage = function(client, message)
         // FIXME: Call our "sessions" "connections".
         // FIXME: Use a hook instead
         // FIXME: Allow to override readwrite access with readonly
+
+        // FIXME: A message might arrive but wont have an auth object, this is obviously bad so we should deny it
+        // Simulate using the load testing tool
+        if(!sessioninfos[client.id].auth){
+          console.error("Auth was never applied to a session.  If you are using the stress-test tool then restart Etherpad and the Stress test tool.")
+          callback();
+        }else{
           var auth = sessioninfos[client.id].auth;
           securityManager.checkAccess(auth.padID, auth.sessionID, auth.token, auth.password, function(err, statusObject)
           {
@@ -246,6 +253,7 @@ exports.handleMessage = function(client, message)
               client.json.send({accessStatus: statusObject.accessStatus})
             }
           });
+        }
       },
       finalHandler
     ]);
@@ -684,7 +692,10 @@ function handleUserChanges(data, cb)
         pad.appendRevision(nlChangeset);
       }
         
-      exports.updatePadClients(pad, callback);
+      exports.updatePadClients(pad, function(er) {
+        ERR(er)
+      });
+      callback();
     }
   ], function(err)
   {