mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-21 16:06:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 26

low hanging lint and some hard coded timeouts

Browse source
This commit is contained in:
John McLear 2021-01-27 04:53:28 +00:00
parent 809670dbea
commit edf1dabe65
36 changed files with 273 additions and 150 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/frontend/specs/select_formatting_buttons.js
View file

@ -1,3 +1,5 @@
'use strict';
describe('select formatting buttons when selection has style applied', function () {
const STYLES = ['italic', 'bold', 'underline', 'strikethrough'];
const SHORTCUT_KEYS = ['I', 'B', 'U', '5']; // italic, bold, underline, strikethrough
@ -21,7 +23,7 @@ describe('select formatting buttons when selection has style applied', function
return $formattingButton.parent().hasClass('selected');
};
var selectLine = function (lineNumber, offsetStart, offsetEnd) {
const selectLine = function (lineNumber, offsetStart, offsetEnd) {
const inner$ = helper.padInner$;
const $line = inner$('div').eq(lineNumber);
helper.selectLines($line, $line, offsetStart, offsetEnd);
@ -40,12 +42,14 @@ describe('select formatting buttons when selection has style applied', function
const testIfFormattingButtonIsDeselected = function (style) {
it(`deselects the ${style} button`, function (done) {
this.timeout(50);
helper.waitFor(() => isButtonSelected(style) === false).done(done);
});
};
const testIfFormattingButtonIsSelected = function (style) {
it(`selects the ${style} button`, function (done) {
this.timeout(50);
helper.waitFor(() => isButtonSelected(style)).done(done);
});
};
@ -58,7 +62,7 @@ describe('select formatting buttons when selection has style applied', function
applyStyleOnLineOnFullLineAndRemoveSelection(line, style, placeCaretOnLine, cb);
};
var applyStyleOnLineOnFullLineAndRemoveSelection = function (line, style, selectTarget, cb) {
const applyStyleOnLineOnFullLineAndRemoveSelection = function (line, style, selectTarget, cb) {
// see if line html has changed
const inner$ = helper.padInner$;
const oldLineHTML = inner$.find('div')[line];
@ -80,7 +84,6 @@ describe('select formatting buttons when selection has style applied', function
const pressFormattingShortcutOnSelection = function (key) {
const inner$ = helper.padInner$;
const chrome$ = helper.padChrome$;
// get the first text element out of the inner iframe
const $firstTextElement = inner$('div').first();
@ -134,6 +137,7 @@ describe('select formatting buttons when selection has style applied', function
});
it('selects the style button', function (done) {
this.timeout(50);
expect(isButtonSelected(style)).to.be(true);
done();
});