express: Change httpUptime to httpStartTime (#4777)

It's better to provide a primitive value and let the consumer of the
metric do math if desired.

Co-authored-by: John McLear <john@mclear.co.uk>
This commit is contained in:
Richard Hansen 2021-02-14 02:50:10 -05:00 committed by GitHub
parent 13a0b0688f
commit e674d9789e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 12 deletions

View file

@ -17,7 +17,7 @@ const logger = log4js.getLogger('http');
let serverName;
const sockets = new Set();
const socketsEvents = new events.EventEmitter();
let startTime = null;
const startTime = stats.settableGauge('httpStartTime');
exports.server = null;
@ -46,11 +46,11 @@ const closeServer = async () => {
await p;
clearTimeout(timeout);
exports.server = null;
startTime.setValue(0);
logger.info('HTTP server closed');
};
exports.createServer = async () => {
stats.gauge('httpUptime', () => startTime == null ? 0 : new Date() - startTime);
console.log('Report bugs at https://github.com/ether/etherpad-lite/issues');
serverName = `Etherpad ${settings.getGitCommit()} (https://etherpad.org)`;
@ -217,7 +217,7 @@ exports.restartServer = async () => {
});
});
await util.promisify(exports.server.listen).bind(exports.server)(settings.port, settings.ip);
startTime = new Date();
startTime.setValue(Date.now());
logger.info('HTTP server listening for connections');
};