mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-22 08:26:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 26

tests: Delete trailing commas in function arguments (#4516)

Browse source 
* lint: Bump eslint-config-etherpad to 1.0.11

* lint: Rerun `eslint --fix` to nuke trailing function call commas

eslint-config-etherpad 1.0.11 changed the comma-dangle rule to
prohibit trailing commas for function arguments. See:
673ab07acf
Re-run the automated fixes to apply the rule change.

This also fixes a few lint issues in changes that were made after
`eslint --fix` was originally run.
This commit is contained in:
Richard Hansen 2020-11-25 04:50:48 -05:00 • committed by GitHub
parent 0a72459b3d
commit e5a3062cbb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/frontend/specs/change_user_color.js
View file

@ -93,7 +93,7 @@ describe('change user color', function () {
$chatInput.sendkeys('{enter}'); // simulate a keypress of enter actually does evt.which = 10 not 13
// check if chat shows up
helper.waitFor(() => chrome$('#chattext').children('p').length !== 0, // wait until the chat message shows up
helper.waitFor(() => chrome$('#chattext').children('p').length !== 0 // wait until the chat message shows up
).done(() => {
const $firstChatMessage = chrome$('#chattext').children('p');
expect($firstChatMessage.css('background-color')).to.be(testColorRGB); // expect the first chat message to be of the user's color

2
tests/frontend/specs/change_user_name.js
View file

@ -60,7 +60,7 @@ describe('change username value', function () {
$chatInput.sendkeys('{enter}'); // simulate a keypress of enter actually does evt.which = 10 not 13
// check if chat shows up
helper.waitFor(() => chrome$('#chattext').children('p').length !== 0, // wait until the chat message shows up
helper.waitFor(() => chrome$('#chattext').children('p').length !== 0 // wait until the chat message shows up
).done(() => {
const $firstChatMessage = chrome$('#chattext').children('p');
const containsJohnMcLear = $firstChatMessage.text().indexOf('John McLear') !== -1; // does the string contain John McLear

4
tests/frontend/specs/clear_authorship_colors.js
View file

@ -28,7 +28,7 @@ describe('clear authorship colors button', function () {
$firstTextElement.sendkeys(sentText);
$firstTextElement.sendkeys('{rightarrow}');
helper.waitFor(() => inner$('div span').first().attr('class').indexOf('author') !== -1, // wait until we have the full value available
helper.waitFor(() => inner$('div span').first().attr('class').indexOf('author') !== -1 // wait until we have the full value available
).done(() => {
// IE hates you if you don't give focus to the inner frame bevore you do a clearAuthorship
inner$('div').first().focus();
@ -80,7 +80,7 @@ describe('clear authorship colors button', function () {
$firstTextElement.sendkeys(sentText);
$firstTextElement.sendkeys('{rightarrow}');
helper.waitFor(() => inner$('div span').first().attr('class').indexOf('author') !== -1, // wait until we have the full value available
helper.waitFor(() => inner$('div span').first().attr('class').indexOf('author') !== -1 // wait until we have the full value available
).done(() => {
// IE hates you if you don't give focus to the inner frame bevore you do a clearAuthorship
inner$('div').first().focus();

2
tests/frontend/specs/importexport.js
View file

@ -136,7 +136,7 @@ describe('import functionality', function () {
const htmlWithBullets = '<html><body><ul class="list-bullet1"><li>bullet line 1</li></ul><ul class="list-bullet1"><li>bullet line 2</li><ul class="list-bullet2"><li>bullet2 line 1</li></ul></ul><ul class="list-bullet1"><ul class="list-bullet2"><ul class="list-bullet3"><ul class="list-bullet4"><li>bullet4 line 2</li><li>bullet4 line 2</li><li>bullet4 line 2</li></ul><li>bullet3 line 1</li></ul></ul><li>bullet2 line 1</li></ul></body></html>';
importrequest(htmlWithBullets, importurl, 'html');
const oldtext = getinnertext();
helper.waitFor(() => oldtext != getinnertext(),
helper.waitFor(() => oldtext != getinnertext()
// return expect(getinnertext()).to.be('\
// <ul class="list-bullet1"><li><span class="">bullet line 1</span></li></ul>\n\
// <ul class="list-bullet1"><li><span class="">bullet line 2</span></li></ul>\n\

2
tests/frontend/specs/responsiveness.js
View file

@ -53,7 +53,7 @@ xdescribe('Responsiveness of Editor', function () {
inner$('div').first().text(text); // Put the text contents into the pad
helper.waitFor(() => // Wait for the new contents to be on the pad
inner$('div').text().length > length,
inner$('div').text().length > length
).done(() => {
expect(inner$('div').text().length).to.be.greaterThan(length); // has the text changed?
const start = Date.now(); // get the start time

2
tests/frontend/specs/timeslider.js
View file

@ -18,7 +18,7 @@ xdescribe('timeslider button takes you to the timeslider of a pad', function ()
const modifiedValue = $firstTextElement.text(); // get the modified value
expect(modifiedValue).not.to.be(originalValue); // expect the value to change
helper.waitFor(() => modifiedValue !== originalValue, // The value has changed so we can..
helper.waitFor(() => modifiedValue !== originalValue // The value has changed so we can..
).done(() => {
const $timesliderButton = chrome$('#timesliderlink');
$timesliderButton.click(); // So click the timeslider link

2
tests/frontend/specs/timeslider_follow.js
View file

@ -42,7 +42,7 @@ describe('timeslider follow', function () {
const lines = helper.linesDiv();
helper.selectLines(lines[0], lines[lines.length - 1]); // select all lines
// probably unnecessary, but wait for the selection to be Range not Caret
await helper.waitForPromise(() => !helper.padInner$.document.getSelection().isCollapsed,
await helper.waitForPromise(() => !helper.padInner$.document.getSelection().isCollapsed
// only supported in FF57+
// return helper.padInner$.document.getSelection().type === 'Range';
);