From d939fd1ef4002926876bd16fb9898cdcd1ab6778 Mon Sep 17 00:00:00 2001 From: cohitre Date: Thu, 21 Jun 2012 21:24:27 -0700 Subject: [PATCH] some cleanup and better scoping. --- .../ep_formatting/static/js/toolbarButtons.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/available_plugins/ep_formatting/static/js/toolbarButtons.js b/available_plugins/ep_formatting/static/js/toolbarButtons.js index d5ffb22cf..6306adb07 100644 --- a/available_plugins/ep_formatting/static/js/toolbarButtons.js +++ b/available_plugins/ep_formatting/static/js/toolbarButtons.js @@ -1,7 +1,6 @@ -var _ = require('ep_etherpad-lite/static/js/underscore') +var _ = require('ep_etherpad-lite/static/js/underscore')._ , padeditor = require('ep_etherpad-lite/static/js/pad_editor').padeditor - , padeditbar = require('ep_etherpad-lite/static/js/pad_editbar').padeditbar - , simpleCommands = ["bold", "italic", "underline", "strikethrough"]; + , padeditbar = require('ep_etherpad-lite/static/js/pad_editbar').padeditbar; function registerCallWithAceCommand(commandName, callback) { padeditbar.registerToolbarCommand(commandName, function () { @@ -10,13 +9,16 @@ function registerCallWithAceCommand(commandName, callback) { } exports.postAceInit = function () { + var simpleCommands = ["bold", "italic", "underline", "strikethrough"] + , undoRedoCommands = ["undo", "redo"]; + _.each(simpleCommands, function (commandName) { registerCallWithAceCommand(commandName, function (ace) { ace.ace_toggleAttributeOnSelection(commandName) }); }); - _.each(["undo", "redo"], function (commandName) { + _.each(undoRedoCommands, function (commandName) { registerCallWithAceCommand(commandName, function (ace) { ace.ace_doUndoRedo(commandName); });