mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-21 07:56:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Do not use cookie for pad shortcuts

Browse source 
Users still cannot choose which shortcuts they want to enable/disable,
so it does not make sense (yet) to have a cookie with that preference.

This can be reverted once we create an UI to change shortcuts, but
PLEASE PLEASE PLEASE do not read the cookie every time handleKeyEvent is
called!!!

This is an adjustment to #2891.
This commit is contained in:
Luiza Pagliari 2017-05-11 12:26:14 -03:00
parent 1ebcf0dc47
commit cf686282ef
3 changed files with 2 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/node/hooks/express/specialpages.js
View file

@ -48,12 +48,6 @@ exports.expressCreateServer = function (hook_name, args, cb) {
res.cookie('language', settings.padOptions.lang);
}
// Enable the pad shortcut keys from settings.json
if (settings.padShortcutEnabled !== undefined)
{
res.cookie('padShortcutEnabled', JSON.stringify(settings.padShortcutEnabled));
}
// The below might break for pads being rewritten
var isReadOnly = req.url.indexOf("/p/r.") === 0;