mirror of
https://github.com/ether/etherpad-lite.git
synced 2025-04-26 10:26:15 -04:00
security: Support proxy with rate limiting and include CI test coverage for nginx rev proxy (#4373)
Previously Etherpad would not pass the correct client IP address through and this caused the rate limiter to limit users behind reverse proxies. This change allows Etherpad to use a client IP passed from a reverse proxy. Note to devs: This header can be spoofed and spoofing the header could be used in an attack. To mitigate additional *steps should be taken by Etherpad site admins IE doing rate limiting at proxy.* This only really applies to large scale deployments but it's worth noting.
This commit is contained in:
parent
dbef630f44
commit
ceb09ce99a
9 changed files with 120 additions and 3 deletions
36
tests/ratelimit/testlimits.sh
Normal file
36
tests/ratelimit/testlimits.sh
Normal file
|
@ -0,0 +1,36 @@
|
|||
#!/usr/bin/env bash
|
||||
|
||||
#sending changesets every 101ms should not trigger ratelimit
|
||||
node send_changesets.js http://127.0.0.1:8081/p/BACKEND_TEST_ratelimit_101ms 101
|
||||
if [[ $? -ne 0 ]];then
|
||||
echo "FAILED: ratelimit was triggered when sending every 101 ms"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
#sending changesets every 99ms should trigger ratelimit
|
||||
node send_changesets.js http://127.0.0.1:8081/p/BACKEND_TEST_ratelimit_99ms 99
|
||||
if [[ $? -ne 1 ]];then
|
||||
echo "FAILED: ratelimit was not triggered when sending every 99 ms"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
#sending changesets every 101ms via proxy
|
||||
node send_changesets.js http://127.0.0.1:8081/p/BACKEND_TEST_ratelimit_101ms 101 &
|
||||
pid1=$!
|
||||
|
||||
#sending changesets every 101ms via second IP and proxy
|
||||
docker exec anotherip node /tmp/send_changesets.js http://172.23.42.1:80/p/BACKEND_TEST_ratelimit_101ms_via_second_ip 101 &
|
||||
pid2=$!
|
||||
|
||||
wait $pid1
|
||||
exit1=$?
|
||||
wait $pid2
|
||||
exit2=$?
|
||||
|
||||
echo "101ms with proxy returned with ${exit1}"
|
||||
echo "101ms via another ip returned with ${exit2}"
|
||||
|
||||
if [[ $exit1 -eq 1 || $exit2 -eq 1 ]];then
|
||||
echo "FAILED: ratelimit was triggered during proxy and requests via second ip"
|
||||
exit 1
|
||||
fi
|
Loading…
Add table
Add a link
Reference in a new issue