From c1f9028d19d08faceaf55891c1db999fd1148f07 Mon Sep 17 00:00:00 2001 From: Marcel Klehr Date: Sun, 18 Nov 2012 20:11:16 +0100 Subject: [PATCH] Fix lang frontend test to 'waitFor' the 'localized' event --- tests/frontend/specs/language.js | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/tests/frontend/specs/language.js b/tests/frontend/specs/language.js index 254493c46..83bb84583 100644 --- a/tests/frontend/specs/language.js +++ b/tests/frontend/specs/language.js @@ -21,14 +21,13 @@ describe("Language select and change", function(){ $languageoption.attr('selected','selected'); $language.change(); - helper.waitFor(function(){ - - var $boldButton = chrome$(".buttonicon-bold").parent(); - //get the title of the bold button - var boldButtonTitle = $boldButton[0]["title"]; - return boldButtonTitle !== undefined; - }).done(function(){ + var localizedEventFired = false; + $(chrome$.window).bind('localized', function() { + localizedEventFired = true; + }) + helper.waitFor(function() { return localizedEventFired;}) + .done(function(){ //get the value of the bold button var $boldButton = chrome$(".buttonicon-bold").parent(); @@ -38,7 +37,6 @@ describe("Language select and change", function(){ //check if the language is now german expect(boldButtonTitle).to.be("Fett (Strg-B)"); done(); - }); }); @@ -58,13 +56,13 @@ describe("Language select and change", function(){ $languageoption.attr('selected','selected'); $language.change(); - helper.waitFor(function(){ + var localizedEventFired = false; + $(chrome$.window).bind('localized', function() { + localizedEventFired = true; + }) - var $boldButton = chrome$(".buttonicon-bold").parent(); - //get the title of the bold button - var boldButtonTitle = $boldButton[0]["title"]; - return boldButtonTitle !== undefined; - }).done(function(){ + helper.waitFor(function() { return localizedEventFired;}) + .done(function(){ //get the value of the bold button var $boldButton = chrome$(".buttonicon-bold").parent();