mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-20 23:46:14 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

undomodule: disallow undoing "clear authorship colors"

Browse source 
Clearing the authorship colors of a document with at least two authors, and then
undoing that action caused a disconnect from the pad.
This change disallows undoing clearing authorship colors in order to prevent
the problem from affecting users, and adds the relative test coverage.

This is a change of behaviour, and is documented in the changelog.

Fixes #2802 (sidestepping it).
This commit is contained in:
John McLear 2020-04-07 00:39:43 +02:00 • committed by muxator
parent ffc718e8c0
commit babf67175c
8 changed files with 90 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/static/js/Changeset.js
View file

@ -791,6 +791,9 @@ exports.textLinesMutator = function (lines) {
}
} else {
var sline = putCurLineInSplice();
if (!curSplice[sline]) {
console.error("curSplice[sline] not populated, actual curSplice contents is ", curSplice, ". Possibly related to https://github.com/ether/etherpad-lite/issues/2802");
}
curSplice[sline] = curSplice[sline].substring(0, curCol) + text + curSplice[sline].substring(curCol);
curCol += text.length;
}