mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-28 11:26:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

caching_middleware: ignore query string when generating cacheKey

Browse source
This commit is contained in:
webzwo0i 2020-11-21 03:13:55 +01:00
parent 0dbec84794
commit b9c82f78b1
2 changed files with 27 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tests/backend/specs/caching_middleware.js
View file

@ -9,6 +9,8 @@ const settings = require('../../../src/node/utils/Settings');
const assert = require('assert').strict;
const url = require('url');
const queryString = require('querystring');
const fs = require('fs');
const path = require('path');
let agent;
@ -165,4 +167,20 @@ describe(__filename, function() {
})
});
context("different callback or version parameter", function(){
it('should never create new files', async function(){
const pathToVar = path.join(__filename, '../../../../var');
// the number of files in ./var should not change during this test
const minifiedFilesBefore = (await fs.promises.readdir(pathToVar)).length;
const resource1 = "/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define";
const resource2 = "/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require";
const resource3 = "/javascripts/lib/ep_etherpad-lite/static/js/ace2_common.js?callback=require.define&v=1234";
await agent.get(resource1);
await agent.get(resource2);
await agent.get(resource3);
const minifiedFilesAfter = (await fs.promises.readdir(pathToVar)).length;
assert.equal(minifiedFilesBefore, minifiedFilesAfter);
})
})
});