mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-22 16:36:15 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibreOffice: Use the async-provided callback to signal errors

Browse source 
This avoids having two callbacks, which improves readability.
This commit is contained in:
Richard Hansen 2021-03-17 19:14:36 -04:00 • committed by John McLear
parent b914a46a87
commit b321267e66
1 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/node/utils/LibreOffice.js
View file

@ -73,10 +73,7 @@ const doConvertTask = (task, callback) => {
libreOfficeLogger.debug(`Renaming ${sourcePath} to ${task.destFile}`); libreOfficeLogger.debug(`Renaming ${sourcePath} to ${task.destFile}`);
fs.rename(sourcePath, task.destFile, callback); fs.rename(sourcePath, task.destFile, callback);
}, },
], (err) => { ], callback);
callback();
task.callback(err);
});
}; };
// Conversion tasks will be queued up, so we don't overload the system // Conversion tasks will be queued up, so we don't overload the system
@ -116,17 +113,15 @@ exports.convertFile = (srcFile, destFile, type, callback) => {
destFile: intermediateFile, destFile: intermediateFile,
type: 'odt', type: 'odt',
fileExtension: 'odt', fileExtension: 'odt',
callback, }, callback),
}),
(callback) => queue.push({ (callback) => queue.push({
srcFile: intermediateFile, srcFile: intermediateFile,
destFile, destFile,
type, type,
callback,
fileExtension, fileExtension,
}), }, callback),
], callback); ], callback);
} else { } else {
queue.push({srcFile, destFile, type, callback, fileExtension}); queue.push({srcFile, destFile, type, fileExtension}, callback);
} }
}; };