From a4639fa638a2f409162c85f11c1138b9db2be140 Mon Sep 17 00:00:00 2001
From: webzwo0i <webzwo0i@c3d2.de>
Date: Wed, 23 Dec 2020 15:41:07 +0100
Subject: [PATCH] test undefined Accept-Encoding with head request

---
 tests/backend/specs/caching_middleware.js | 24 +++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/tests/backend/specs/caching_middleware.js b/tests/backend/specs/caching_middleware.js
index 0b1b34f93..c840de61b 100644
--- a/tests/backend/specs/caching_middleware.js
+++ b/tests/backend/specs/caching_middleware.js
@@ -76,9 +76,18 @@ describe(__filename, function () {
             assert.match(res.header['content-type'], /application\/javascript/);
             assert.equal(res.header['content-encoding'], undefined);
             assert.equal(isPlaintextResponse(res.text, resource), true);
-            return;
           })));
     });
+    
+    // need to use head here - cant unset Accept-Encoding in GET requests 
+    it('head request without Accept-Encoding header does not set Content-Encoding', async function () {
+      await agent
+          .head(packages[0]) 
+          .then((res) => {
+            assert.match(res.header['content-type'], /application\/javascript/);
+            assert.equal(res.header['content-encoding'], undefined);
+          });
+    });
 
     it('gets packages compressed with Accept-Encoding gzip', async function () {
       await Promise.all(packages.map(async (resource) => await agent.get(resource)
@@ -88,7 +97,6 @@ describe(__filename, function () {
             assert.match(res.header['content-type'], /application\/javascript/);
             assert.equal(res.header['content-encoding'], 'gzip');
             assert.equal(isPlaintextResponse(res.text, resource), false);
-            return;
           })));
     });
 
@@ -126,10 +134,19 @@ describe(__filename, function () {
             assert.match(res.header['content-type'], /application\/javascript/);
             assert.equal(res.header['content-encoding'], undefined);
             assert.equal(isPlaintextResponse(res.text, resource), true);
-            return;
           })));
     });
 
+    // need to use head here - cant unset Accept-Encoding in GET requests 
+    it('head request without Accept-Encoding header does not set Content-Encoding', async function () {
+      await agent
+          .head(packages[0]) 
+          .then((res) => {
+            assert.match(res.header['content-type'], /application\/javascript/);
+            assert.equal(res.header['content-encoding'], undefined);
+          });
+    });
+
     it('gets packages compressed with Accept-Encoding gzip', async function () {
       await Promise.all(packages.map(async (resource) => await agent.get(resource)
           .set('Accept-Encoding', 'gzip')
@@ -138,7 +155,6 @@ describe(__filename, function () {
             assert.match(res.header['content-type'], /application\/javascript/);
             assert.equal(res.header['content-encoding'], 'gzip');
             assert.equal(isPlaintextResponse(res.text, resource), false);
-            return;
           })));
     });