mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-23 08:56:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

SocketIORouter: Don't crash if message handler throws

Browse source
This commit is contained in:
Richard Hansen 2021-09-06 05:51:57 -04:00
parent 320e5c1109
commit 9f9adb369b
2 changed files with 25 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/tests/backend/specs/socketio.js
View file

@ -460,7 +460,7 @@ describe(__filename, function () {
await disconnected;
});
it('handleMessage', async function () {
it('handleMessage (success)', async function () {
let serverSocket;
const want = {
component: this.test.fullTitle(),
@ -480,5 +480,24 @@ describe(__filename, function () {
socket.send(want);
assert.deepEqual(await got, want);
});
it('handleMessage (error)', async function () {
let receive;
const received = new Promise((resolve) => receive = resolve);
socketIoRouter.addComponent(this.test.fullTitle(), new class extends Module {
handleMessage(socket, message) {
if (message.throw) throw new Error('injected');
receive();
}
}());
socket = await connect();
const tx = (msg = {}) => {
msg = Object.assign({component: this.test.fullTitle(), protocolVersion: 2}, msg);
socket.send(msg);
};
tx({throw: true});
tx();
await received;
});
});
});