From 98066184b2730f3a3e4217730878d83ac6c78111 Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Thu, 26 Nov 2020 00:34:08 -0500 Subject: [PATCH] PadMessageHandler: Don't fill in default name or color It should be the client's responsibility to handle null name or color. In the case of author names, passing null to the client allows users to fill in the names of other users (via a suggestUserName CLIENT_MESSAGE). --- src/node/handler/PadMessageHandler.js | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/src/node/handler/PadMessageHandler.js b/src/node/handler/PadMessageHandler.js index 84ec9b5c1..9f8901f73 100644 --- a/src/node/handler/PadMessageHandler.js +++ b/src/node/handler/PadMessageHandler.js @@ -1140,23 +1140,6 @@ async function handleClientReady(socket, message, authorID) { return; } - // default fallback color to use if authorInfo.colorId is null - const defaultColor = '#daf0b2'; - - // For some reason sometimes name isn't set - // Catch this issue here and use a fixed name. - if (!authorInfo.name) { - console.warn('handleClientReady(): client submitted no author name. Using "Anonymous". See: issue #3612'); - authorInfo.name = 'Anonymous'; - } - - // For some reason sometimes colorId isn't set - // Catch this issue here and use a fixed color. - if (!authorInfo.colorId) { - console.warn(`handleClientReady(): author "${authorInfo.name}" has no property colorId. Using the default color ${defaultColor}. See issue #3612`); - authorInfo.colorId = defaultColor; - } - // Send the new User a Notification about this other user const msg = { type: 'COLLABROOM',