From 8d73c29f1a18095ce50aba9e216fc85be42bda8a Mon Sep 17 00:00:00 2001 From: webzwo0i Date: Mon, 23 Nov 2020 01:45:49 +0100 Subject: [PATCH] run frontend workflow only on push run all other workflows on push and on PRs from external repos This should prevent running workflows twice in case of a PR from a branch of the main repo --- .github/workflows/backend-tests.yml | 10 ++++++++++ .github/workflows/dockerfile.yml | 5 +++++ .github/workflows/frontend-tests.yml | 7 +------ .github/workflows/lint-package-lock.yml | 5 +++++ .github/workflows/load-test.yml | 10 ++++++++++ .github/workflows/rate-limit.yml | 5 +++++ 6 files changed, 36 insertions(+), 6 deletions(-) diff --git a/.github/workflows/backend-tests.yml b/.github/workflows/backend-tests.yml index 483d71f96..e50491d23 100644 --- a/.github/workflows/backend-tests.yml +++ b/.github/workflows/backend-tests.yml @@ -5,6 +5,11 @@ on: [push, pull_request] jobs: withoutplugins: + # run on pushes to any branch + # run on PRs from external forks + if: | + (github.event_name != 'pull_request') + || (github.event.pull_request.head.repo.id != github.event.pull_request.base.repo.id) name: without plugins runs-on: ubuntu-latest @@ -26,6 +31,11 @@ jobs: run: tests/frontend/travis/runnerBackend.sh withplugins: + # run on pushes to any branch + # run on PRs from external forks + if: | + (github.event_name != 'pull_request') + || (github.event.pull_request.head.repo.id != github.event.pull_request.base.repo.id) name: with Plugins runs-on: ubuntu-latest diff --git a/.github/workflows/dockerfile.yml b/.github/workflows/dockerfile.yml index 9814d0906..8f6d5c3b0 100644 --- a/.github/workflows/dockerfile.yml +++ b/.github/workflows/dockerfile.yml @@ -5,6 +5,11 @@ on: [push, pull_request] jobs: dockerfile: + # run on pushes to any branch + # run on PRs from external forks + if: | + (github.event_name != 'pull_request') + || (github.event.pull_request.head.repo.id != github.event.pull_request.base.repo.id) name: build image and run connectivity test runs-on: ubuntu-latest diff --git a/.github/workflows/frontend-tests.yml b/.github/workflows/frontend-tests.yml index 3e2113726..7a2846dbe 100644 --- a/.github/workflows/frontend-tests.yml +++ b/.github/workflows/frontend-tests.yml @@ -1,12 +1,9 @@ name: "Frontend tests" -# any branch is useful for testing before a PR is submitted -on: [push, pull_request] +on: [push] jobs: withoutplugins: - # don't run on PRs from forks - if: github.event.pull_request.head.repo.full_name == 'ether/etherpad-lite' || github.event_name == 'push' name: without plugins runs-on: ubuntu-latest @@ -43,8 +40,6 @@ jobs: tests/frontend/travis/runner.sh withplugins: - # don't run on PRs from forks - if: github.event.pull_request.head.repo.full_name == 'ether/etherpad-lite' || github.event_name == 'push' name: with plugins runs-on: ubuntu-latest diff --git a/.github/workflows/lint-package-lock.yml b/.github/workflows/lint-package-lock.yml index b6be450f2..beef64ffe 100644 --- a/.github/workflows/lint-package-lock.yml +++ b/.github/workflows/lint-package-lock.yml @@ -5,6 +5,11 @@ on: [push, pull_request] jobs: lint-package-lock: + # run on pushes to any branch + # run on PRs from external forks + if: | + (github.event_name != 'pull_request') + || (github.event.pull_request.head.repo.id != github.event.pull_request.base.repo.id) name: package-lock.json runs-on: ubuntu-latest diff --git a/.github/workflows/load-test.yml b/.github/workflows/load-test.yml index d7d01ecdb..095adc785 100644 --- a/.github/workflows/load-test.yml +++ b/.github/workflows/load-test.yml @@ -5,6 +5,11 @@ on: [push, pull_request] jobs: withoutplugins: + # run on pushes to any branch + # run on PRs from external forks + if: | + (github.event_name != 'pull_request') + || (github.event.pull_request.head.repo.id != github.event.pull_request.base.repo.id) name: without plugins runs-on: ubuntu-latest @@ -22,6 +27,11 @@ jobs: run: tests/frontend/travis/runnerLoadTest.sh withplugins: + # run on pushes to any branch + # run on PRs from external forks + if: | + (github.event_name != 'pull_request') + || (github.event.pull_request.head.repo.id != github.event.pull_request.base.repo.id) name: with Plugins runs-on: ubuntu-latest diff --git a/.github/workflows/rate-limit.yml b/.github/workflows/rate-limit.yml index 8f0db1ad0..4bdfc2194 100644 --- a/.github/workflows/rate-limit.yml +++ b/.github/workflows/rate-limit.yml @@ -5,6 +5,11 @@ on: [push, pull_request] jobs: ratelimit: + # run on pushes to any branch + # run on PRs from external forks + if: | + (github.event_name != 'pull_request') + || (github.event.pull_request.head.repo.id != github.event.pull_request.base.repo.id) name: test runs-on: ubuntu-latest steps: