mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-23 17:06:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 33

GroupManager: Clean up any mappings when deleting a group

Browse source
This commit is contained in:
Richard Hansen 2021-11-28 01:47:44 -05:00 • committed by John McLear
parent 5b37a56197
commit 777d045246
3 changed files with 36 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/tests/backend/specs/api/sessionsAndGroups.js
View file

@ -2,6 +2,7 @@
const assert = require('assert').strict;
const common = require('../../common');
const db = require('../../../../node/db/DB');
let agent;
const apiKey = common.apiKey;
@ -89,13 +90,33 @@ describe(__filename, function () {
});
it('createGroupIfNotExistsFor', async function () {
await agent.get(`${endPoint('createGroupIfNotExistsFor')}&groupMapper=management`)
const mapper = makeid();
let groupId;
await agent.get(`${endPoint('createGroupIfNotExistsFor')}&groupMapper=${mapper}`)
.expect(200)
.expect('Content-Type', /json/)
.expect((res) => {
assert.equal(res.body.code, 0);
assert(res.body.data.groupID);
groupId = res.body.data.groupID;
assert(groupId);
});
// Passing the same mapper should return the same group ID.
await agent.get(`${endPoint('createGroupIfNotExistsFor')}&groupMapper=${mapper}`)
.expect(200)
.expect('Content-Type', /json/)
.expect((res) => {
assert.equal(res.body.code, 0);
assert.equal(res.body.data.groupID, groupId);
});
// Deleting the group should clean up the mapping.
assert.equal(await db.get(`mapper2group:${mapper}`), groupId);
await agent.get(`${endPoint('deleteGroup')}&groupID=${groupId}`)
.expect(200)
.expect('Content-Type', /json/)
.expect((res) => {
assert.equal(res.body.code, 0);
});
assert(await db.get(`mapper2group:${mapper}`) == null);
});
// Test coverage for https://github.com/ether/etherpad-lite/issues/4227