allow option to make pad names case-insensitive (#5501) by @DanielHabenicht

* New option to make pad names case-insensitive

fixes #3844

* fix helper.gotoTimeslider()

* fix helper.aNewPad() return value

* Update src/node/utils/Settings.js

Co-authored-by: Richard Hansen <rhansen@rhansen.org>

* remove timeout

* rename enforceLowerCasePadIds to lowerCasePadIds

* use before and after hooks

* update with socket specific test

* enforce sanitizing padID for websocket connections

- only enforce for newly created pads, to combat case-sensitive pad name hijacking

* Added updated package.json file.

---------

Co-authored-by: Richard Hansen <rhansen@rhansen.org>
Co-authored-by: SamTV12345 <40429738+samtv12345@users.noreply.github.com>

src/tests/frontend/helper.js

@@ -181,7 +181,9 @@ const helper = {};
     helper.padOuter$.fx.off = true;
     helper.padInner$.fx.off = true;
 
-    return opts.id;
+    // Don't return opts.id -- the server might have redirected the browser to a transformed version
+    // of the requested pad ID.
+    return helper.padChrome$.window.clientVars.padId;
   };
 
   helper.newAdmin = async (page) => {

src/tests/frontend/helper/methods.js

@@ -175,9 +175,8 @@ helper.disableStickyChatviaIcon = async () => {
  */
 helper.gotoTimeslider = async (revision) => {
   revision = Number.isInteger(revision) ? `#${revision}` : '';
-  const iframe = $('#iframe-container iframe');
-  iframe.attr('src', `${iframe.attr('src')}/timeslider${revision}`);
-
+  helper.padChrome$.window.location.href =
+      `${helper.padChrome$.window.location.pathname}/timeslider${revision}`;
   await helper.waitForPromise(() => helper.timesliderTimerTime() &&
       !Number.isNaN(new Date(helper.timesliderTimerTime()).getTime()), 10000);
 };