mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-22 08:26:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 26

checkAllPads: Increase performance/resilience

Browse source 
Performance: Don't preload pads. Check for pool only once per pad.
Resilience: Handle missing revision.
This commit is contained in:
Claas Augner 2018-03-09 14:02:22 +01:00 • committed by GitHub
parent 5c864ec47d
commit 5c915062e1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 79 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

39
bin/checkAllPads.js
View file

@ -1,5 +1,5 @@
/* /*
This is a debug tool. It checks all revisions of all pads for data corruption This is a debug tool. It checks all revisions for data corruption
*/ */
if(process.argv.length != 2) if(process.argv.length != 2)
@ -35,20 +35,27 @@ async.series([
padManager.listAllPads(function(err, res) padManager.listAllPads(function(err, res)
{ {
var padIds = res.padIDs; padIds = res.padIDs;
pads = [];
async.forEach(padIds, function(padId, callback) {
padManager.getPad(padId, function(err, pad) {
pads.push(pad);
callback(err); callback(err);
})
}, callback);
}); });
}, },
function (callback) function (callback)
{ {
async.forEach(pads, function(pad, callback) async.forEach(padIds, function(padId, callback)
{ {
padManager.getPad(padId, function(err, pad) {
if (err) {
callback(err);
}
//check if the pad has a pool
if(pad.pool === undefined )
{
console.error("[" + pad.id + "] Missing attribute pool");
callback();
return;
}
//create an array with key kevisions //create an array with key kevisions
//key revisions always save the full pad atext //key revisions always save the full pad atext
var head = pad.getHeadRevisionNumber(); var head = pad.getHeadRevisionNumber();
@ -87,18 +94,17 @@ async.series([
return; return;
} }
//check if the pad has a pool //check if the revision exists
if(pad.pool === undefined ) if (revisions[keyRev] == null) {
{ console.error("[" + pad.id + "] Missing revision " + keyRev);
console.error("[" + pad.id + "] Attribute pool is missing");
callback(); callback();
return; return;
} }
//check if there is a atext in the keyRevisions //check if there is a atext in the keyRevisions
if(revisions[keyRev] == null || revisions[keyRev].meta === undefined || revisions[keyRev].meta.atext === undefined) if(revisions[keyRev].meta === undefined || revisions[keyRev].meta.atext === undefined)
{ {
console.error("[" + pad.id + "] No atext in key revision " + keyRev); console.error("[" + pad.id + "] Missing atext in revision " + keyRev);
callback(); callback();
return; return;
} }
@ -110,7 +116,7 @@ async.series([
{ {
try try
{ {
//console.log("check revision " + i); //console.log("[" + pad.id + "] check revision " + i);
var cs = revisions[i].changeset; var cs = revisions[i].changeset;
atext = Changeset.applyToAText(cs, atext, apool); atext = Changeset.applyToAText(cs, atext, apool);
} }
@ -125,6 +131,7 @@ async.series([
callback(); callback();
}); });
}, callback); }, callback);
});
}, callback); }, callback);
} }
], function (err) ], function (err)