mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-23 08:56:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

editor: fix enter key keep line in view (#4639)

Browse source
This commit is contained in:
John McLear 2021-02-06 19:56:59 +00:00 • committed by GitHub
parent c969ae58c2
commit 4862d6fa9c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 39 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/tests/frontend/specs/enter.js
View file

@ -6,7 +6,6 @@ describe('enter keystroke', function () {
helper.newPad(cb);
this.timeout(60000);
});
it('creates a new line & puts cursor onto a new line', function (done) {
const inner$ = helper.padInner$;
@ -28,4 +27,32 @@ describe('enter keystroke', function () {
done();
});
});
it('enter is always visible after event', async function () {
const originalLength = helper.padInner$('div').length;
let $lastLine = helper.padInner$('div').last();
// simulate key presses to enter content
let i = 0;
const numberOfLines = 15;
let previousLineLength = originalLength;
while (i < numberOfLines) {
$lastLine = helper.padInner$('div').last();
$lastLine.sendkeys('{enter}');
await helper.waitFor(() => helper.padInner$('div').length > previousLineLength);
previousLineLength = helper.padInner$('div').length;
// check we can see the caret..
i++;
}
await helper.waitFor(() => helper.padInner$('div').length === numberOfLines + originalLength);
// is edited line fully visible?
const lastLine = helper.padInner$('div').last();
const bottomOfLastLine = lastLine.offset().top + lastLine.height();
const scrolledWindow = helper.padChrome$('iframe')[0];
const scrolledAmount = scrolledWindow.contentWindow.pageYOffset +
scrolledWindow.contentWindow.innerHeight;
await helper.waitFor(() => scrolledAmount >= bottomOfLastLine);
});
});