mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-24 17:36:14 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 33

tests: remove loadSettings.js for backend tests.

Browse source 
The old loadSettings.js was a way of customizing settings upon load, because
the Settings module did not offer this functionality. But it did not work well,
since all the default settings were not loaded.

Let's get rid of loadSettings.js for the bulk of the tests (the "backend"
specs). For the "container" specs, we'll keep it in place until/if we rewrite
Settings.js making it less brittle.
This commit is contained in:
muxator 2020-04-14 01:10:19 +02:00 • committed by muxator
parent 419f17371c
commit 44186edbc5
8 changed files with 23 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tests/container/loadSettings.js
View file

@ -1,8 +1,15 @@
/*
* ACHTUNG: this file was copied & modified from the analogous
* <basedir>/tests/backend/loadSettings.js
* ACHTUNG: this file is a hack used to load "settings.json.docker" instead of
* "settings.json", since in its present form the Settings module does
* not allow it.
* This is a remnant of an analogous file that was placed in
* <basedir>/tests/backend/loadSettings.js
*
* TODO: unify those two files, and merge in a single one.
* TODO: modify the Settings module:
* 1) no side effects on module load
* 2) write a factory method that loads a configuration file (taking the
* file name from the command line, a function argument, or falling
* back to a default)
*/
var jsonminify = require(__dirname+"/../../src/node_modules/jsonminify");