From 3ab044f4361a691abbaa26036688d9464202e6f4 Mon Sep 17 00:00:00 2001 From: SamTV12345 <40429738+samtv12345@users.noreply.github.com> Date: Tue, 27 Jun 2023 15:32:46 +0200 Subject: [PATCH] Remove double parsing of JSON. --- src/static/js/pluginfw/installer.js | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/static/js/pluginfw/installer.js b/src/static/js/pluginfw/installer.js index 7fab2e823..6c5784b00 100644 --- a/src/static/js/pluginfw/installer.js +++ b/src/static/js/pluginfw/installer.js @@ -79,16 +79,9 @@ exports.getAvailablePlugins = (maxCacheAge) => { await axios.get('https://static.etherpad.org/plugins.json') .then(pluginsLoaded => { - let plugins; - try { - plugins = JSON.parse(pluginsLoaded.data); - } catch (err) { - logger.error(`error parsing plugins.json: ${err.stack || err}`); - plugins = []; - } - exports.availablePlugins = plugins; + exports.availablePlugins = pluginsLoaded.data; cacheTimestamp = nowTimestamp; - resolve(plugins); + resolve(exports.availablePlugins); }) }) }