From 395db73eb1281a27ce80c4ca919cfdd3889d1bd9 Mon Sep 17 00:00:00 2001
From: muxator <a.mux@inwind.it>
Date: Wed, 31 Oct 2018 23:00:45 +0100
Subject: [PATCH] ImportHandler: early return by condition inversion

No functional changes
---
 src/node/handler/ImportHandler.js | 36 ++++++++++++++++---------------
 1 file changed, 19 insertions(+), 17 deletions(-)

diff --git a/src/node/handler/ImportHandler.js b/src/node/handler/ImportHandler.js
index c34debab1..28a7b2071 100644
--- a/src/node/handler/ImportHandler.js
+++ b/src/node/handler/ImportHandler.js
@@ -132,27 +132,29 @@ exports.doImport = function(req, res, padId)
     },
     function(callback) {
       var fileEnding = path.extname(srcFile).toLowerCase()
-      var fileIsEtherpad = (fileEnding === ".etherpad");
+      var fileIsNotEtherpad = (fileEnding !== ".etherpad");
 
-      if(fileIsEtherpad){
-        // we do this here so we can see if the pad has quit ea few edits
-        padManager.getPad(padId, function(err, _pad){
-          var headCount = _pad.head;
-          if(headCount >= 10){
-            apiLogger.warn("Direct database Import attempt of a pad that already has content, we wont be doing this")
-            return callback("padHasData");
-          }
+      if (fileIsNotEtherpad) {
+        callback();
 
-          fs.readFile(srcFile, "utf8", function(err, _text){
-            directDatabaseAccess = true;
-            importEtherpad.setPadRaw(padId, _text, function(err){
-              callback();
-            });
+        return;
+      }
+
+      // we do this here so we can see if the pad has quit ea few edits
+      padManager.getPad(padId, function(err, _pad){
+        var headCount = _pad.head;
+        if(headCount >= 10){
+          apiLogger.warn("Direct database Import attempt of a pad that already has content, we wont be doing this")
+          return callback("padHasData");
+        }
+
+        fs.readFile(srcFile, "utf8", function(err, _text){
+          directDatabaseAccess = true;
+          importEtherpad.setPadRaw(padId, _text, function(err){
+            callback();
           });
         });
-      }else{
-        callback();
-      }
+      });
     },
     //convert file to html
     function(callback) {