From 37d61756d71e9963ec5e89b94815eea1c002f612 Mon Sep 17 00:00:00 2001
From: John McLear <john@mclear.co.uk>
Date: Mon, 26 Jun 2023 17:37:10 +0100
Subject: [PATCH] test against node 20

---
 .github/workflows/backend-tests.yml               | 8 ++++----
 .github/workflows/frontend-admin-tests.yml        | 2 +-
 .github/workflows/frontend-tests.yml              | 6 +++---
 .github/workflows/lint-package-lock.yml           | 2 +-
 .github/workflows/load-test.yml                   | 6 +++---
 .github/workflows/rate-limit.yml                  | 2 +-
 .github/workflows/upgrade-from-latest-release.yml | 2 +-
 .github/workflows/windows.yml                     | 4 ++--
 8 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/backend-tests.yml b/.github/workflows/backend-tests.yml
index c16b79a5e..485ec0cc1 100644
--- a/.github/workflows/backend-tests.yml
+++ b/.github/workflows/backend-tests.yml
@@ -18,7 +18,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [14, 16, 18]
+        node: [16, 18, 20]
     steps:
       -
         name: Checkout repository
@@ -55,7 +55,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [14, 16, 18]
+        node: [16, 18, 20]
     steps:
       -
         name: Checkout repository
@@ -124,7 +124,7 @@ jobs:
       -
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             src/package-lock.json
@@ -157,7 +157,7 @@ jobs:
       -
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             src/package-lock.json
diff --git a/.github/workflows/frontend-admin-tests.yml b/.github/workflows/frontend-admin-tests.yml
index c10cc0d5a..57336cc76 100644
--- a/.github/workflows/frontend-admin-tests.yml
+++ b/.github/workflows/frontend-admin-tests.yml
@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [14, 16, 18]
+        node: [16, 18, 20]
 
     steps:
       -
diff --git a/.github/workflows/frontend-tests.yml b/.github/workflows/frontend-tests.yml
index 89dd72866..653ee9d60 100644
--- a/.github/workflows/frontend-tests.yml
+++ b/.github/workflows/frontend-tests.yml
@@ -34,7 +34,7 @@ jobs:
       -
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             src/package-lock.json
@@ -98,7 +98,7 @@ jobs:
       -
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             src/package-lock.json
@@ -126,7 +126,7 @@ jobs:
       # Etherpad core dependencies must be installed after installing the
       # plugin's dependencies, otherwise npm will try to hoist common
       # dependencies by removing them from src/node_modules and installing them
-      # in the top-level node_modules. As of v6.14.10, npm's hoist logic appears
+      # in the top-level node_modules. As of v6.20.10, npm's hoist logic appears
       # to be buggy, because it sometimes removes dependencies from
       # src/node_modules but fails to add them to the top-level node_modules.
       # Even if npm correctly hoists the dependencies, the hoisting seems to
diff --git a/.github/workflows/lint-package-lock.yml b/.github/workflows/lint-package-lock.yml
index bc05a1a52..e3401a94f 100644
--- a/.github/workflows/lint-package-lock.yml
+++ b/.github/workflows/lint-package-lock.yml
@@ -22,7 +22,7 @@ jobs:
       -
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             src/package-lock.json
diff --git a/.github/workflows/load-test.yml b/.github/workflows/load-test.yml
index 9d8c4fd9b..6eb3afad7 100644
--- a/.github/workflows/load-test.yml
+++ b/.github/workflows/load-test.yml
@@ -22,7 +22,7 @@ jobs:
       -
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             src/package-lock.json
@@ -52,7 +52,7 @@ jobs:
       -
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             src/package-lock.json
@@ -109,7 +109,7 @@ jobs:
       -
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             src/package-lock.json
diff --git a/.github/workflows/rate-limit.yml b/.github/workflows/rate-limit.yml
index 7df7aa4ce..005002b08 100644
--- a/.github/workflows/rate-limit.yml
+++ b/.github/workflows/rate-limit.yml
@@ -22,7 +22,7 @@ jobs:
       -
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             src/package-lock.json
diff --git a/.github/workflows/upgrade-from-latest-release.yml b/.github/workflows/upgrade-from-latest-release.yml
index a00e9540d..69eb08d8e 100644
--- a/.github/workflows/upgrade-from-latest-release.yml
+++ b/.github/workflows/upgrade-from-latest-release.yml
@@ -18,7 +18,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [14, 16, 18]
+        node: [16, 18, 20]
     steps:
       -
         name: Check out latest release
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
index bcd8532a3..53fe33d07 100644
--- a/.github/workflows/windows.yml
+++ b/.github/workflows/windows.yml
@@ -28,7 +28,7 @@ jobs:
       -
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             src/package-lock.json
@@ -108,7 +108,7 @@ jobs:
       -
         uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 20
           cache: 'npm'
           cache-dependency-path: |
             etherpad/src/package-lock.json