From 3237f8d123351c8525eecc9f86c88880326cf061 Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Sat, 14 Aug 2021 22:15:40 -0400 Subject: [PATCH] ace2_inner: Simplify iteration over line number divs --- src/static/js/ace2_inner.js | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/static/js/ace2_inner.js b/src/static/js/ace2_inner.js index c315a31d1..a46978139 100644 --- a/src/static/js/ace2_inner.js +++ b/src/static/js/ace2_inner.js @@ -3603,15 +3603,10 @@ function Ace2Inner(editorInfo, cssManagers) { } } - let sidebarLine = sideDivInner.firstChild; - currentLine = 0; - while (sidebarLine && currentLine <= sideDivInner.children.length) { - if (lineOffsets[currentLine] != null) { - sidebarLine.style.height = `${lineOffsets[currentLine]}px`; - sidebarLine.style.lineHeight = `${lineHeights[currentLine]}px`; - } - sidebarLine = sidebarLine.nextSibling; - currentLine++; + for (const [i, sideDivLine] of Array.prototype.entries.call(sideDivInner.children)) { + if (lineOffsets[i] == null) continue; + sideDivLine.style.height = `${lineOffsets[i]}px`; + sideDivLine.style.lineHeight = `${lineHeights[i]}px`; } };