From 283100db6b59a721adcbc9ea8ff00dae488bf289 Mon Sep 17 00:00:00 2001
From: muxator <a.mux@inwind.it>
Date: Sun, 20 Oct 2019 00:02:00 +0200
Subject: [PATCH] runtime: deprecate node 8.x. Require node >= 10.13.0 starting
 from Etherpad 1.8.3

Nodejs 8 will be EOLed on December 31th, 2019 (https://github.com/nodejs/Release).

This means any future Etherpad version released from 2020 on should require at
least the next LTS (10.13.0). Let's keep some margin and decide that the first
Etherpad version dropping node 8 compatibility will be 1.8.3.

Closes #3650.
---
 README.md          | 4 ++--
 src/node/server.js | 6 ++----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/README.md b/README.md
index ae80caf89..685ba8966 100644
--- a/README.md
+++ b/README.md
@@ -9,7 +9,7 @@ Etherpad is a real-time collaborative editor scalable to thousands of simultaneo
 # Installation
 
 ## Requirements
-- `nodejs` >= **8.9.0**
+- `nodejs` >= **8.9.0** (preferred: `nodejs` >= **10.13.0**). Please note that starting Jan 1st, 2020, nodejs 8.x is deprecated.
 
 ## GNU/Linux and other UNIX-like systems
 
@@ -21,7 +21,7 @@ git clone --branch master https://github.com/ether/etherpad-lite.git && cd ether
 ```
 
 ### Manual install
-You'll need git and [node.js](https://nodejs.org) installed (minimum required Node version: **8.9.0**).
+You'll need git and [node.js](https://nodejs.org) installed (minimum required Node version: **8.9.0**, preferred: >= **10.13.0**).
 
 **As any user (we recommend creating a separate user called etherpad):**
 
diff --git a/src/node/server.js b/src/node/server.js
index f683de82c..8e57b3997 100755
--- a/src/node/server.js
+++ b/src/node/server.js
@@ -34,11 +34,9 @@ log4js.replaceConsole();
 NodeVersion.enforceMinNodeVersion('8.9.0');
 
 /*
- * As of Etherpad 1.8.0, we do not have any further Node version deprecation in
- * place.
- *
- * NodeVersion.checkDeprecationStatus('10.13.0', '1.9.0');
+ * Etherpad 1.8.3 will require at least nodejs 10.13.0.
  */
+NodeVersion.checkDeprecationStatus('10.13.0', '1.8.3');
 
 /*
  * start up stats counting system