From 27363bf729d50c7f302981d42df111edaf76af41 Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Sat, 14 Aug 2021 20:51:18 -0400 Subject: [PATCH] ace2_inner: Add line number divs directly, not via fragment There's no layout thrashing so the fragment doesn't provide any benefit. --- src/static/js/ace2_inner.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/static/js/ace2_inner.js b/src/static/js/ace2_inner.js index 5e9ba297a..b0b0d3fb5 100644 --- a/src/static/js/ace2_inner.js +++ b/src/static/js/ace2_inner.js @@ -3604,8 +3604,6 @@ function Ace2Inner(editorInfo, cssManagers) { } if (newNumLines !== lineNumbersShown) { - const fragment = outerDoc.createDocumentFragment(); - // Create missing line and apply height while (lineNumbersShown < newNumLines) { lineNumbersShown++; @@ -3615,10 +3613,9 @@ function Ace2Inner(editorInfo, cssManagers) { div.style.lineHeight = `${lineHeights[currentLine]}px`; } $(div).append($(`${String(lineNumbersShown)}`)); - fragment.appendChild(div); + sideDivInner.appendChild(div); currentLine++; } - sideDivInner.appendChild(fragment); // Remove extra lines while (lineNumbersShown > newNumLines) {