mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-20 07:35:05 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 27

pad: Don't throw on socket.io error

Browse source
This commit is contained in:
Richard Hansen 2021-02-10 18:54:19 -05:00 • committed by John McLear
parent fc9f236977
commit 2301c6ec83
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -41,6 +41,7 @@
### Notable fixes ### Notable fixes
* Enter key now stays in focus when inserted at bottom of viewport. * Enter key now stays in focus when inserted at bottom of viewport.
* Suppressed benign socket.io connection errors
* Interface no longer loses color variants on disconnect/reconnect event. * Interface no longer loses color variants on disconnect/reconnect event.
* Removed npm.load to support npm7. * Removed npm.load to support npm7.
* General code quality is further significantly improved. * General code quality is further significantly improved.

4
src/static/js/pad.js
View file

@ -271,7 +271,9 @@ const handshake = () => {
pad.collabClient.setStateIdle(); pad.collabClient.setStateIdle();
pad.collabClient.setIsPendingRevision(true); pad.collabClient.setIsPendingRevision(true);
} }
throw new Error(`socket.io connection error: ${JSON.stringify(error)}`); // Don't throw an exception. Error events do not indicate problems that are not already
// addressed by reconnection logic, so throwing an exception each time there's a socket.io error
// just annoys users and fills logs.
}); });
socket.on('message', (obj) => { socket.on('message', (obj) => {