mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-20 23:46:14 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

PadMessageHandler: Delete redundant check

Browse source 
This check is already made very early in `handleMessage`.
This commit is contained in:
Richard Hansen 2020-09-04 22:45:55 -04:00 • committed by John McLear
parent d4162341e7
commit 17096919e0
1 changed files with 0 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/node/handler/PadMessageHandler.js
View file

@ -259,19 +259,6 @@ exports.handleMessage = async function(client, message)
} }
} }
/*
* In a previous version of this code, an "if (message)" wrapped the
* following series of async calls [now replaced with await calls]
* This ugly "!Boolean(message)" is a lame way to exactly negate the truthy
* condition and replace it with an early return, while being sure to leave
* the original behaviour unchanged.
*
* A shallower code could maybe make more evident latent logic errors.
*/
if (!Boolean(message)) {
return;
}
let dropMessage = await handleMessageHook(); let dropMessage = await handleMessageHook();
if (!dropMessage) { if (!dropMessage) {