mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-23 17:06:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 33

chat: Plumb message object end to end

Browse source 
This will make it possible for future commits to add hooks that allow
plugins to augment chat messages with arbitrary metadata.
This commit is contained in:
Richard Hansen 2021-10-26 00:56:27 -04:00
parent f1f4ed7c58
commit 0f47ca9046
9 changed files with 113 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/tests/frontend/helper/methods.js
View file

@ -12,7 +12,7 @@ helper.spyOnSocketIO = () => {
} else if (msg.data.type === 'USER_NEWINFO') {
helper.userInfos.push(msg);
} else if (msg.data.type === 'CHAT_MESSAGE') {
helper.chatMessages.push(msg.data);
helper.chatMessages.push(msg.data.message);
} else if (msg.data.type === 'CHAT_MESSAGES') {
helper.chatMessages.push(...msg.data.messages);
}

6
src/tests/frontend/specs/chat_hooks.js
View file

@ -1,11 +1,13 @@
'use strict';
describe('chat hooks', function () {
let ChatMessage;
let hooks;
const hooksBackup = {};
const loadPad = async (opts = {}) => {
await helper.aNewPad(opts);
ChatMessage = helper.padChrome$.window.require('ep_etherpad-lite/static/js/ChatMessage');
({hooks} = helper.padChrome$.window.require('ep_etherpad-lite/static/js/pluginfw/plugin_defs'));
for (const [name, defs] of Object.entries(hooks)) {
hooksBackup[name] = defs;
@ -61,10 +63,10 @@ describe('chat hooks', function () {
});
}
it('message is an object', async function () {
it('message is a ChatMessage object', async function () {
await Promise.all([
checkHook('chatNewMessage', ({message}) => {
expect(message).to.be.an('object');
expect(message).to.be.a(ChatMessage);
}),
helper.sendChatMessage(`${this.test.title}{enter}`),
]);