mirrors/etherpad-lite
1
0
Fork 0
mirror of https://github.com/ether/etherpad-lite.git synced 2025-04-23 17:06:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25

tests: Factor out USER_CHANGES/ACCEPT_COMMIT helpers

Browse source 
This will make it possible for other tests to reuse the code.
This commit is contained in:
Richard Hansen 2021-12-19 16:47:45 -05:00
parent 674a0ccedc
commit 02d1b90d30
2 changed files with 90 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

72
src/tests/backend/specs/messages.js
View file

@ -36,27 +36,10 @@ describe(__filename, function () {
});
describe('USER_CHANGES', function () {
const sendUserChanges = (changeset, apool = new AttributePool()) => {
socket.json.send({
type: 'COLLABROOM',
component: 'pad',
data: {
type: 'USER_CHANGES',
baseRev: rev,
changeset,
apool: new AttributePool(),
},
});
};
const sendUserChanges =
async (changeset) => await common.sendUserChanges(socket, {baseRev: rev, changeset});
const assertAccepted = async (wantRev) => {
const msg = await common.waitForSocketEvent(socket, 'message');
assert.deepEqual(msg, {
type: 'COLLABROOM',
data: {
type: 'ACCEPT_COMMIT',
newRev: wantRev,
},
});
await common.waitForAcceptCommit(socket, wantRev);
rev = wantRev;
};
const assertRejected = async () => {
@ -65,38 +48,55 @@ describe(__filename, function () {
};
it('changes are applied', async function () {
sendUserChanges('Z:1>5+5$hello');
await assertAccepted(rev + 1);
await Promise.all([
assertAccepted(rev + 1),
sendUserChanges('Z:1>5+5$hello'),
]);
assert.equal(pad.text(), 'hello\n');
});
it('bad changeset is rejected', async function () {
sendUserChanges('this is not a valid changeset');
await assertRejected();
await Promise.all([
assertRejected(),
sendUserChanges('this is not a valid changeset'),
]);
});
it('retransmission is accepted, has no effect', async function () {
sendUserChanges('Z:1>5+5$hello');
await assertAccepted(rev + 1);
const cs = 'Z:1>5+5$hello';
await Promise.all([
assertAccepted(rev + 1),
sendUserChanges(cs),
]);
--rev;
sendUserChanges('Z:1>5+5$hello');
await assertAccepted(rev + 1);
await Promise.all([
assertAccepted(rev + 1),
sendUserChanges(cs),
]);
assert.equal(pad.text(), 'hello\n');
});
it('identity changeset is accepted, has no effect', async function () {
sendUserChanges('Z:1>5+5$hello');
await assertAccepted(rev + 1);
sendUserChanges('Z:6>0$');
await assertAccepted(rev);
await Promise.all([
assertAccepted(rev + 1),
sendUserChanges('Z:1>5+5$hello'),
]);
await Promise.all([
assertAccepted(rev),
sendUserChanges('Z:6>0$'),
]);
assert.equal(pad.text(), 'hello\n');
});
it('non-identity changeset with no net change is accepted, has no effect', async function () {
sendUserChanges('Z:1>5+5$hello');
await assertAccepted(rev + 1);
sendUserChanges('Z:6>0-5+5$hello');
await assertAccepted(rev);
await Promise.all([
assertAccepted(rev + 1),
sendUserChanges('Z:1>5+5$hello'),
]);
await Promise.all([
assertAccepted(rev),
sendUserChanges('Z:6>0-5+5$hello'),
]);
assert.equal(pad.text(), 'hello\n');
});
});