CyberChef/src/core
XlogicX 1a9a070c3b
Removal of unnecessary error condition
This situation occurs because the dependancy (zlibjs/bin/rawinflate.min.js) doesn't do a sanity check on distances going back farther than the current buffer.

For example:
DEFLATE data of '123' and then a length of 9 going back a distance of 6
ASCIIHEX: 333432869300

! infgen 3.0 output
!
last			! 1
fixed			! 01
literal '1		! 10000110
literal '2		! 01000110
literal '3		! 11000110
match 9 6		! 1 00100 1110000
infgen warning: distance too far back (6/3)
end			! 0000000
			! 0

We only have 3 characters, we shouldn't be able to seek 6 characters back. But rawinflate.min.js doesn't check for this like the infgen debug tool (and others) would. So CyberChef would happily provide this as the result:
123...123...
Where the dots are just nulls of likley empty memory preceding the actual buffer

So with the example in this source
// e.g. Input data of [8b, 1d, dc, 44]

last			! 1
fixed			! 01
literal ']		! 10110001
match 158 5		! 0 00100 11011 10000011
infgen warning: distance too far back (5/1)

This means we have a literal ']' and then we are asking for 158 more characters and to find them a distance of 5 back. This explains why the ']', why it repeats every 5, and why it is a length > 158.

This code should just be removed; it isn't justified. Being that this issue is a lack of sanity checking in a dependancy, and that this routine only catches the symptom of one of the nearly unlimited edge cases like this, AND it could filter out correct inputs, such as a recipe of this as input to RAWDEFLATE
]OMG[]HAX[]OMG[]HAX[]OMG[]HAX[]OMG[]HAX[]OMG[]HAX[]OMG[]HAX[]OMG[]HAX[]OMG[]HAX[]OMG[]HAX[]OMG[]HAX[]OMG[]HAX[]OMG[]HAX[]OMG[]HAX[]OMG[]HAX[]OMG[]HAX[]OMG[]HAX
Then getting an error with the INFLATE even though the input is actually valid.
2022-10-06 14:02:27 -04:00
..
config Tidied Cetacean ciphers 2022-07-08 17:16:35 +01:00
dishTypes Issue 998: DishJSON should only replace undefined with new ArrayBuffer not null or false 2020-03-28 20:27:59 +00:00
errors Always use mjs imports 2021-09-17 08:48:04 +02:00
lib fix protobuf field order 2022-07-21 16:36:15 +02:00
operations Removal of unnecessary error condition 2022-10-06 14:02:27 -04:00
vendor Fixed tesseract issue 2020-05-27 15:00:34 +01:00
Chef.mjs Suppressed highlighting errors 2020-03-18 13:40:16 +00:00
ChefWorker.js Updated to Node 17 2022-03-25 14:59:54 +00:00
Dish.mjs Added a CodeQL workflow to check for bugs through code analysis. Fixed numerous bugs and implemented safeguards as already reported. 2021-02-10 13:13:19 +00:00
Ingredient.mjs Preserve null data when type is number in prepare 2020-01-18 14:56:17 +00:00
Operation.mjs Imports now specify the file extension to support Node v12 2019-07-09 12:23:59 +01:00
Recipe.mjs Updated to Node 17 2022-03-25 14:59:54 +00:00
Utils.mjs CodeQL fixes 2022-04-14 16:57:46 +01:00