mirrors/CyberChef
1
0
Fork 0
mirror of https://github.com/gchq/CyberChef.git synced 2025-05-08 07:21:02 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

[#181] move edit-favourites button to original place in the template, so it is not visible anymore during load. Update TODO.md accordingly

Browse source
This commit is contained in:
Robin Scholtes 2023-04-18 22:29:17 +12:00
parent e74d7998fd
commit f1340f1249
2 changed files with 9 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/web/TODO.md
View file

@ -7,7 +7,6 @@
- restore desktop UI - restore desktop UI
### Mobile UI: ### Mobile UI:
- on load, initial `#edit-favourites` in operations should be hidden until the dropdown is opened
- bootstrap native 'x' in `input[type="search"]` should clear input value and - bootstrap native 'x' in `input[type="search"]` should clear input value and
then display `categories` rather than close the entire dropdown then display `categories` rather than close the entire dropdown
- on click of `input[type="search]`, `favourites` briefly opens and closes. Would be nice not to have that - on click of `input[type="search]`, `favourites` briefly opens and closes. Would be nice not to have that
@ -22,11 +21,12 @@
### JS: ### JS:
- `core/Recipe.mjs`, `core/lib/Magic.js` return imports to original - `core/Recipe.mjs`, `core/lib/Magic.js` return imports to original
- `waiters/OperationsWaiter.mjs` isVisible is pretty generic so probably move it ( to manager? ) - `waiters/OperationsWaiter.mjs` setVisibility is pretty generic so probably move it ( to manager? )
- `App.mjs` add a window resize listener for functions in setup if ( breakpoint ) - `App.mjs` add a window resize listener for functions in setup if ( breakpoint )
### Misc: ### Misc:
- check for remaining todos - check for remaining todos
- check for remaining comments to be deleted
- check and add browser vendor prefixes throughout stylesheets where needed - check and add browser vendor prefixes throughout stylesheets where needed
- comb through CSS and improve organisation for better DevX - comb through CSS and improve organisation for better DevX
- write / complete UI tests - write / complete UI tests

15
src/web/html/index.html
View file

@ -143,6 +143,13 @@
<!-- <div id="preloader-error" class="loading-error"></div>--> <!-- <div id="preloader-error" class="loading-error"></div>-->
<!-- </div>--> <!-- </div>-->
<!-- End preloader overlay --> <!-- End preloader overlay -->
<button type="button"
class="btn btn-warning bmd-btn-icon"
id="edit-favourites"
data-toggle="tooltip"
title="Edit favourites">
<i class="material-icons">star</i>
</button>
<div id="content-wrapper"> <div id="content-wrapper">
<!-- banner --> <!-- banner -->
@ -202,14 +209,6 @@
Operations Operations
<span class="pane-controls hide-on-maximised-output"> <span class="pane-controls hide-on-maximised-output">
<button type="button"
class="btn btn-warning bmd-btn-icon"
id="edit-favourites"
data-toggle="tooltip"
title="Edit favourites">
<i class="material-icons">star</i>
</button>
<button type="button" <button type="button"
class="btn bmd-btn-icon mobile-only hidden" class="btn bmd-btn-icon mobile-only hidden"
id="reset-operations" id="reset-operations"