bit of refactoring

This commit is contained in:
Robin Scholtes 2023-05-09 18:42:14 +12:00
parent 793acb54de
commit f1257ea356
3 changed files with 9 additions and 14 deletions

View file

@ -330,7 +330,11 @@ class App {
} }
/** /**
* Set mobile splitters * Set mobile layout
*
* We don't actually use splitters on mobile, but we leverage the splitters
* to create our desired layout. This prevents some problems when resizing
* from mobile to desktop and vice versa
*/ */
setMobileSplitter() { setMobileSplitter() {
if (this.columnSplitter) this.columnSplitter.destroy(); if (this.columnSplitter) this.columnSplitter.destroy();
@ -860,15 +864,7 @@ class App {
* *
*/ */
updateVisibility( elm, isVisible ){ updateVisibility( elm, isVisible ){
if ( isVisible ) { isVisible ? elm.classList.remove("hidden") : elm.classList.add("hidden");
if ( elm.classList.contains("hidden")) {
elm.classList.remove("hidden");
}
} else if ( isVisible === false ) {
if ( !elm.classList.contains("hidden")){
elm.classList.add("hidden");
}
}
} }
/** /**

View file

@ -7,7 +7,6 @@
- need long press checks on mobile to add favourites ( recipe is done ) > - need long press checks on mobile to add favourites ( recipe is done ) >
- check on window resizing - check on window resizing
- raw bites dropup thingy is unusable
- shannon entropy thingies - shannon entropy thingies
- backspace on fs view should close max view. Keep making the same mistake and navigating away when for instance recipe is expanded and double click the window to fs > resolve. Reset layout - backspace on fs view should close max view. Keep making the same mistake and navigating away when for instance recipe is expanded and double click the window to fs > resolve. Reset layout

View file

@ -346,9 +346,9 @@ class OperationsWaiter {
search.value = ''; search.value = '';
} }
this.app.updateVisibility(document.getElementById( "categories"), false ); this.app.updateVisibility(document.getElementById("categories"), false);
this.app.updateVisibility(document.getElementById( "search-results"), false ); this.app.updateVisibility(document.getElementById("search-results"), false);
this.app.updateVisibility(document.getElementById("close-operations-dropdown"), false ); this.app.updateVisibility(document.getElementById("close-operations-dropdown"), false);
} }
/** /**