mirrors/CyberChef
1
0
Fork 0
mirror of https://github.com/gchq/CyberChef.git synced 2025-05-07 06:57:12 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

[#181] remove double border in Operations - search. Update todo ( started testing on real mobile device )

Browse source
This commit is contained in:
Robin Scholtes 2023-04-20 22:00:20 +12:00
parent d3eac1b208
commit f1008cff56
3 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/web/TODO.md
View file

@ -5,11 +5,13 @@
### Mobile UI:
#### Operations:
- on mobile, there is almost no visual feedback when adding an operation to the recipe list. Since the recipe list is not visible like on desktop, this is very confusing UX
- on mobile UI, there is almost no visual feedback when adding an operation to the recipe list. Since the recipe list is not visible like on desktop, this is very confusing UX
#### General mobile UX:
#### Mobile UI on real device:
- test *thoroughly* with keyboard popping up because that messes with view-heights on mobile probably and might make it a very frustrating experience
- test drag and drop etc. Regular mobile events / UX
- view-heights not correct due to variable taskbar on mobile devices
- adding an operation only works with drag and drop, not on double tap or the like. This todo is related to the remaining mobile UI one ( I think maybe add a checkmark on double tap, then remove it again on double tap or when recipe list gets cleared )
### Desktop UI:
### General UI:
@ -19,8 +21,8 @@
- `core/Recipe.mjs`, `core/lib/Magic.js` return imports to original
### Misc:
- remove ln 215 in gruntfile ( for mobile testing )
- comb through CSS and improve organisation for better DevX
- special checks for features removed from mobile ( like multiple tabs, minimise, maximise etc. )
- write / complete UI tests
- delete this file when done :)

10
src/web/html/index.html
View file

@ -137,11 +137,11 @@
<body>
<!-- Preloader overlay -->
<!-- <div id="loader-wrapper">-->
<!-- <div id="preloader" class="loader"></div>-->
<!-- <div id="preloader-msg" class="loading-msg"></div>-->
<!-- <div id="preloader-error" class="loading-error"></div>-->
<!-- </div>-->
<div id="loader-wrapper">
<div id="preloader" class="loader"></div>
<div id="preloader-msg" class="loading-msg"></div>
<div id="preloader-error" class="loading-error"></div>
</div>
<!-- End preloader overlay -->
<button type="button"
class="btn btn-warning bmd-btn-icon"

4
src/web/stylesheets/components/operations/_search.css
View file

@ -5,7 +5,5 @@
#search {
padding-left: 10px;
padding-right: 10px;
background-image:
linear-gradient(to top, var(--input-highlight-colour) 2px, rgba(0, 0, 0, 0) 2px),
linear-gradient(to top, var(--primary-border-colour) 1px, rgba(0, 0, 0, 0) 1px);
background-image: none;
}