incorporate ArrayBuffer base Dish type. Add global file shim to node index. Fix Buffer -> ArrayBuffer transformation

src/core/Dish.mjs

@@ -387,7 +387,7 @@ class Dish {
                 [Dish.BIG_NUMBER]:      () => Promise.resolve(DishBigNumber.toArrayBuffer.bind(this)()),
                 [Dish.JSON]:            () => Promise.resolve(DishJSON.toArrayBuffer.bind(this)()),
                 [Dish.FILE]:            () => DishFile.toArrayBuffer.bind(this)(),
-                [Dish.LIST_FILE]:       () => DishListFile.toArrayBuffer.bind(this)(),
+                [Dish.LIST_FILE]:       () => Promise.resolve(DishListFile.toArrayBuffer.bind(this)()),
                 [Dish.BYTE_ARRAY]:      () => Promise.resolve(DishByteArray.toArrayBuffer.bind(this)()),
             },
             node: {

src/core/Utils.mjs

@@ -94,7 +94,7 @@ class Utils {
         const paddedBytes = new Array(numBytes);
         paddedBytes.fill(padByte);
 
-        Array.prototype.map.call(arr, function(b, i) {
+        [...arr].forEach((b, i) => {
             paddedBytes[i] = b;
         });
 
@@ -1033,8 +1033,10 @@ class Utils {
         if (!Utils.isNode()) {
             throw new TypeError("Browser environment cannot support readFileSync");
         }
-
+        // Resist using node's Buffer.buffer here - this yields a 8192 length byteArray
-        return file.data.buffer;
+        // regardless of the length of the buffer.
+        const arrayBuffer = Uint8Array.from(file.data);
+        return arrayBuffer.buffer;
     }
 
 

src/core/dishTranslationTypes/DishListFile.mjs

@@ -17,14 +17,7 @@ class DishListFile extends DishTranslationType {
      */
     static toArrayBuffer() {
         DishListFile.checkForValue(this.value);
-        if (Utils.isNode()) {
+        this.value = DishListFile.concatenateTypedArrays(...this.value).buffer;
-            // TODO
-            this.value = [].concat.apply([], this.value.map(f => Utils.readFileSync(f)).map(b => Array.prototype.slice.call(b)));
-        } else {
-            return new Promise((resolve, reject) => {
-                resolve(DishListFile.concatenateTypedArrays(...this.value).buffer);
-            });
-        }
     }
 
     /**

src/node/config/scripts/generateNodeIndex.mjs

@@ -41,6 +41,7 @@ let code = `/**
 import "babel-polyfill";
 import NodeDish from "./NodeDish";
 import { _wrap, help, bake, _explainExludedFunction } from "./api";
+import File from "./File";
 import {
     // import as core_ to avoid name clashes after wrap.
 `;
@@ -53,6 +54,8 @@ includedOperations.forEach((op) => {
 code +=`
 } from "../core/operations/index";
 
+global.File = File;
+
 // Define global environment functions
 global.ENVIRONMENT_IS_WORKER = function() {
     return typeof importScripts === "function";

src/node/index.mjs

@@ -12,6 +12,7 @@
 import "babel-polyfill";
 import NodeDish from "./NodeDish";
 import { _wrap, help, bake, _explainExludedFunction } from "./api";
+import File from "./File";
 import {
     // import as core_ to avoid name clashes after wrap.
     A1Z26CipherDecode as core_A1Z26CipherDecode,
@@ -316,6 +317,8 @@ import {
 
 } from "../core/operations/index";
 
+global.File = File;
+
 // Define global environment functions
 global.ENVIRONMENT_IS_WORKER = function() {
     return typeof importScripts === "function";

tests/lib/utils.mjs

@@ -79,11 +79,6 @@ export function logTestReport(testStatus, results) {
         }
     }
 
-    if (!testStatus.allTestsPassing) {
-        console.log("\nFailing tests:\n");
-        results.filter(r => r.status !== "passing").forEach(handleTestResult);
-    }
-
     process.exit(testStatus.allTestsPassing ? 0 : 1);
 }