mirrors/CyberChef
1
0
Fork 0
mirror of https://github.com/gchq/CyberChef.git synced 2025-05-08 15:25:01 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

A few annotations and event listener removals on disconnectedCallback

Browse source
This commit is contained in:
Robin Scholtes 2023-07-21 11:47:00 +12:00
parent 6b0b368564
commit 5f32df891b
3 changed files with 25 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/web/components/c-operation-li.mjs
View file

@ -31,7 +31,13 @@ export class COperationLi extends HTMLElement {
this.addEventListener('dblclick', this.handleDoubleClick.bind(this));
}
// todo: dont think I need config separately, just use this.app.operations[name].xx?
/**
* Remove listeners on disconnectedCallback
*/
disconnectedCallback() {
this.removeEventListener("click", this.handleClick.bind(this));
this.removeEventListener("dblclick", this.handleDoubleClick.bind(this));
}
/**
* @fires OperationsWaiter#operationDblclick on double click
@ -52,6 +58,9 @@ export class COperationLi extends HTMLElement {
this.app.addFavourite(this.name);
this.updateFavourite(true);
}
if (e.target === this.querySelector("i.remove-icon")) {
this.remove();
}
}
/**
@ -168,6 +177,9 @@ export class COperationLi extends HTMLElement {
return icon;
}
/**
* Update favourite icon for this list item and add 'favourite' class
*/
updateFavourite(isFavourite) {
if (isFavourite) {
this.querySelector("li").classList.add("favourite");